Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 8b69ccf

Browse files
achingbrainalanshaw
authored andcommitted
test: remove tests that test duck typing (#314)
These tests test code that looks for relevant fields in the passed arguments to turn into DAGNodes in both the Go and JS implementations, which looks like the right thing to do.
1 parent 0a3f5f2 commit 8b69ccf

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

js/src/dag/put.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,6 @@ module.exports = (createCommon, options) => {
6565
}, done)
6666
})
6767

68-
// This works because dag-cbor will just treat pbNode as a regular object
69-
it.skip('should not put dag-pb node with wrong multicodec', (done) => {
70-
ipfs.dag.put(pbNode, 'dag-cbor', 'sha3-512', (err) => {
71-
expect(err).to.exist()
72-
done()
73-
})
74-
})
75-
7668
it('should put dag-cbor with default hash func (sha2-256)', (done) => {
7769
ipfs.dag.put(cborNode, {
7870
format: 'dag-cbor',
@@ -87,16 +79,6 @@ module.exports = (createCommon, options) => {
8779
}, done)
8880
})
8981

90-
it('should not put dag-cbor node with wrong multicodec', (done) => {
91-
ipfs.dag.put(cborNode, {
92-
format: 'dag-pb',
93-
hashAlg: 'sha3-512'
94-
}, (err) => {
95-
expect(err).to.exist()
96-
done()
97-
})
98-
})
99-
10082
it('should return the cid', (done) => {
10183
ipfs.dag.put(cborNode, {
10284
format: 'dag-cbor',

0 commit comments

Comments
 (0)