fix: Support api endpoint with no port defined

Author: vasco-santos

package.json

@@ -33,6 +33,7 @@
     "detect-node": "^2.0.3",
     "flatmap": "0.0.3",
     "glob": "^7.1.2",
+    "ip-regex": "^3.0.0",
     "ipfs-block": "~0.7.1",
     "ipfs-unixfs": "~0.1.14",
     "ipld-dag-cbor": "~0.12.0",

src/index.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const ipRegex = require('ip-regex')
 const multiaddr = require('multiaddr')
 const loadCommands = require('./utils/load-commands')
 const getConfig = require('./utils/default-config')
@@ -15,7 +16,14 @@ function IpfsAPI (hostOrMultiaddr, port, opts) {
   } catch (e) {
     if (typeof hostOrMultiaddr === 'string') {
       config.host = hostOrMultiaddr
-      config.port = port && typeof port !== 'object' ? port : config.port
+      const addrParts = hostOrMultiaddr.split(':')
+
+      if (addrParts.length === 2 && ipRegex.v4({ exact: true }).test(addrParts[0]) &&
+          (!port || typeof port === 'object')) {
+        config.port = undefined
+      } else {
+        config.port = port
+      }
     }
   }
 

test/constructor.spec.js

@@ -50,6 +50,12 @@ describe('ipfs-api constructor tests', () => {
       clientWorks(ipfsAPI(apiAddr, { protocol: 'http' }), done)
     })
 
+    it('host', (done) => {
+      const splitted = apiAddr.split('/')
+
+      clientWorks(ipfsAPI(splitted[2]), done)
+    })
+
     it('host, port', (done) => {
       const splitted = apiAddr.split('/')