Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 716daca

Browse files
hackergrrldaviddias
authored andcommitted
Update 'files' and 'util' command paths.
1 parent c6d77be commit 716daca

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

src/load-commands.js

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
'use strict'
22

33
function requireCommands () {
4-
return {
5-
add: require('./api/add'),
6-
addFiles: require('./api/add-files'),
7-
addUrl: require('./api/add-url'),
4+
var cmds = {
85
bitswap: require('./api/bitswap'),
96
block: require('./api/block'),
107
cat: require('./api/cat'),
@@ -13,7 +10,6 @@ function requireCommands () {
1310
dht: require('./api/dht'),
1411
diag: require('./api/diag'),
1512
id: require('./api/id'),
16-
files: require('./api/files'),
1713
log: require('./api/log'),
1814
ls: require('./api/ls'),
1915
mount: require('./api/mount'),
@@ -26,6 +22,24 @@ function requireCommands () {
2622
update: require('./api/update'),
2723
version: require('./api/version')
2824
}
25+
26+
// TODO: crowding the 'files' namespace temporarily for interface-ipfs-core
27+
// compatibility, until 'files vs mfs' naming decision is resolved.
28+
cmds.files = function (send) {
29+
var files = require('./api/files')(send)
30+
files.add = require('./api/add')(send)
31+
return files
32+
}
33+
34+
cmds.util = function (send) {
35+
var util = {
36+
addFiles: require('./api/add-files')(send),
37+
addUrl: require('./api/add-url')(send)
38+
}
39+
return util
40+
}
41+
42+
return cmds
2943
}
3044

3145
function loadCommands (send) {

test/api/add.spec.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('.add', () => {
2323
content: new Buffer(testfile)
2424
}
2525

26-
apiClients.a.add([file], (err, res) => {
26+
apiClients.a.files.add([file], (err, res) => {
2727
expect(err).to.not.exist
2828

2929
const added = res[0] != null ? res[0] : res
@@ -36,7 +36,7 @@ describe('.add', () => {
3636

3737
it('add buffer', (done) => {
3838
let buf = new Buffer(testfile)
39-
apiClients.a.add(buf, (err, res) => {
39+
apiClients.a.files.add(buf, (err, res) => {
4040
expect(err).to.not.exist
4141

4242
expect(res).to.have.length(1)
@@ -52,7 +52,7 @@ describe('.add', () => {
5252
return done()
5353
}
5454

55-
apiClients.a.add(testfileBig, (err, res) => {
55+
apiClients.a.files.add(testfileBig, (err, res) => {
5656
expect(err).to.not.exist
5757

5858
expect(res).to.have.length(1)
@@ -80,7 +80,7 @@ describe('.add', () => {
8080
})
8181

8282
it('local fs: add nested dir (follow symlinks)', (done) => {
83-
apiClients.a.addFiles(path.join(__dirname, '/../test-folder'), { recursive: true }, (err, res) => {
83+
apiClients.a.util.addFiles(path.join(__dirname, '/../test-folder'), { recursive: true }, (err, res) => {
8484
if (isNode) {
8585
expect(err).to.not.exist
8686

@@ -98,7 +98,7 @@ describe('.add', () => {
9898
})
9999

100100
it('local fs: add nested dir (don\'t follow symlinks)', (done) => {
101-
apiClients.a.addFiles(path.join(__dirname, '/../test-folder'), { recursive: true, followSymlinks: false }, (err, res) => {
101+
apiClients.a.util.addFiles(path.join(__dirname, '/../test-folder'), { recursive: true, followSymlinks: false }, (err, res) => {
102102
if (isNode) {
103103
expect(err).to.not.exist
104104

@@ -138,7 +138,7 @@ describe('.add', () => {
138138
}
139139
]
140140

141-
apiClients.a.add(dirs, { recursive: true }, (err, res) => {
141+
apiClients.a.files.add(dirs, { recursive: true }, (err, res) => {
142142
expect(err).to.not.exist
143143

144144
const added = res[res.length - 1]
@@ -154,7 +154,7 @@ describe('.add', () => {
154154
stream.push('Hello world')
155155
stream.push(null)
156156

157-
apiClients.a.add(stream, (err, res) => {
157+
apiClients.a.files.add(stream, (err, res) => {
158158
expect(err).to.not.exist
159159

160160
const added = res[0] != null ? res[0] : res
@@ -167,7 +167,7 @@ describe('.add', () => {
167167

168168
it('add url', (done) => {
169169
const url = 'https://github.com/raw/ipfs/js-ipfs-api/2a9cc63d7427353f2145af6b1a768a69e67c0588/README.md'
170-
apiClients.a.addUrl(url, (err, res) => {
170+
apiClients.a.util.addUrl(url, (err, res) => {
171171
expect(err).to.not.exist
172172

173173
const added = res[0] != null ? res[0] : res
@@ -181,7 +181,7 @@ describe('.add', () => {
181181
describe('promise', () => {
182182
it('add buffer', () => {
183183
let buf = new Buffer(testfile)
184-
return apiClients.a.add(buf)
184+
return apiClients.a.files.add(buf)
185185
.then((res) => {
186186
const added = res[0] != null ? res[0] : res
187187
const mh = bs58.encode(added.multihash()).toString()

0 commit comments

Comments
 (0)