Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Test Back-Pressure #727

Closed
bvand opened this issue Apr 1, 2018 · 3 comments
Closed

Test Back-Pressure #727

bvand opened this issue Apr 1, 2018 · 3 comments
Labels

Comments

@bvand
Copy link

bvand commented Apr 1, 2018

There are currently no tests confirming that back-pressure is working correctly. We should add such a test so that future changes don't break back-pressure.

The test could "create a dummy API server endpoint that takes a long time to reply and see if the source gets paused when the high water mark is reached" (see #702).

@alanshaw
Copy link
Contributor

@bvand are you working on adding these (as you mentioned in #702)?

@bvand
Copy link
Author

bvand commented May 11, 2018

@alanshaw I haven't done any work on this, feel free to pick it up!

@daviddias daviddias added the ready label Jun 4, 2018
@achingbrain
Copy link
Collaborator

Everything is async iterators now, which have a back pressure mechanism built in. Please open a new issue against ipfs/js-ipfs if this is still required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants