Skip to content

Scope and name of this artifact #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidel opened this issue Apr 4, 2018 · 5 comments
Closed

Scope and name of this artifact #11

lidel opened this issue Apr 4, 2018 · 5 comments

Comments

@lidel
Copy link
Member

lidel commented Apr 4, 2018

(we had some casual discussions, but I feel we should make a final decision on this)

Are we going to continue shipping fonts and icons together with css?
Will UI Kit be a single npm package?

  • If we want to keep everything under ipfs-css name perhaps it time to change its name to something less CSS centric (ipfs-ui-kit)?
  • Or does it make sense to ship UI Kit as multiple packages?
    (ipfs-ui-kit-icons+ipfs-ui-kit-css+ipfs-ui-kit-fonts)
@nothingismagick
Copy link
Contributor

There is a similar discussion over at quasar-cli, which is also about the naming of a folder. I think that ipfs-ui-kitis a good solution to the semantic issue. At the moment, the src of this repo here is css - but maybe at some point in the future it might add js, gulp, less, docker pipelines for building assets - who knows...

@lidel
Copy link
Member Author

lidel commented May 2, 2018

Let's time-box this decision until next week.
We should either change the name to ipfs-ui-kit (github repo + npm) or just agree to keep ipfs-css an close this issue.

@olizilla @alanshaw thoughts on this?

@alanshaw
Copy link
Member

alanshaw commented May 2, 2018

Personally I'd leave it as ipfs-css. Fonts are referenced by the CSS so need to be included. Having icons available is convenient but I don't think it warrants a name change.

I also think people are more likely to search for ipfs css than ipfs ui kit.

@olizilla
Copy link
Member

olizilla commented May 2, 2018

I'm happy with ipfs-css.

More generally, my plan is to focus on the webui rebuild, and once we're all happy with it, we can update the style guide and this repo with what we learn along the way.

@lidel
Copy link
Member Author

lidel commented May 7, 2018

Alright, we are keeping ipfs-css 👍

@lidel lidel closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants