feat: windows interop (#154)

* test: close IPFSRepo before deleting its files

* chore: run on appveyor

* chore: upgrade packages

* chore: debugging appveyor failure

* test: more appveyor debugging

* test: use os.tmpdir() not '/tmp'

* test: timeout issue

* test: fix error reporting

* test: Math.Random => uuid

Math.Random can create collisions.  Using uuid should not create a collision.

* test: all tests can timeout, need global timeout specified

* test: bitswap-mock multi peer is just too long, skip it

* fix package.json

* test: [email protected] breaks us.  reverting to 0.18.2

* chore: update repo version

* chore: update deps

* bring back the test

Author: richardschneider

appveyor.yml

@@ -0,0 +1,23 @@
+environment:
+  matrix:
+    - nodejs_version: "6"
+    - nodejs_version: "8"
+
+# cache:
+#  - node_modules
+
+platform:
+  - x64
+
+install:
+  - ps: Install-Product node $env:nodejs_version $env:platform
+  - npm install
+
+test_script:
+  - node --version
+  - npm --version
+  - npm test
+
+build: off
+
+version: "{build}"

package.json

@@ -8,16 +8,16 @@
     "./test/utils/create-temp-repo-nodejs.js": "./test/utils/create-temp-repo-browser.js"
   },
   "scripts": {
-    "test": "aegir test --target node --target browser",
-    "test:browser": "aegir test --target browser",
-    "test:node": "aegir test --target node",
+    "test": "aegir test -t node -t browser",
+    "test:browser": "aegir test -t browser",
+    "test:node": "aegir test -t node",
     "lint": "aegir lint",
     "release": "aegir release",
     "release-minor": "aegir release --type minor",
     "release-major": "aegir release --type major",
     "bench": "node benchmarks/index",
     "build": "aegir build",
-    "coverage": "aegir coverage -u",
+    "coverage": "aegir coverage --provider codecov",
     "docs": "aegir docs"
   },
   "repository": {
@@ -43,7 +43,7 @@
     "dirty-chai": "^2.0.1",
     "ipfs-repo": "~0.18.3",
     "libp2p": "~0.13.0",
-    "libp2p-kad-dht": "~0.5.1",
+    "libp2p-kad-dht": "~0.6.0",
     "libp2p-multiplex": "~0.5.0",
     "libp2p-secio": "~0.8.1",
     "libp2p-tcp": "~0.11.1",
@@ -52,7 +52,7 @@
     "ncp": "^2.0.0",
     "peer-book": "~0.5.1",
     "peer-id": "~0.10.2",
-    "peer-info": "~0.11.0",
+    "peer-info": "~0.11.1",
     "rimraf": "^2.6.2",
     "safe-buffer": "^5.1.1"
   },
@@ -73,7 +73,7 @@
     "multicodec": "~0.2.5",
     "multihashing-async": "~0.4.7",
     "protons": "^1.0.0",
-    "pull-defer": "^0.2.2",
+    "pull-defer": "~0.2.2",
     "pull-length-prefixed": "^1.3.0",
     "pull-pushable": "^2.1.1",
     "pull-stream": "^3.6.1",

test/bitswap-mock-internals.js

@@ -110,7 +110,7 @@ describe('bitswap with mocks', () => {
     })
 
     it('multi peer', function (done) {
-      this.timeout(40 * 1000)
+      this.timeout(80 * 1000)
       const bs = new Bitswap(mockLibp2pNode(), repo.blocks)
 
       let others

test/bitswap.js

@@ -99,7 +99,9 @@ describe('bitswap without DHT', function () {
   })
 })
 
-describe('bitswap with DHT', () => {
+describe('bitswap with DHT', function () {
+  this.timeout(20 * 1000)
+
   let nodes
 
   before((done) => {

test/fixtures/repo/version

@@ -1 +1 @@
-5
+6

test/utils/create-temp-repo-nodejs.js

@@ -1,22 +1,29 @@
 'use strict'
 
 const IPFSRepo = require('ipfs-repo')
-const path = require('path')
+const pathJoin = require('path').join
+const os = require('os')
 const ncp = require('ncp')
 const rimraf = require('rimraf')
+const series = require('async/series')
 
-const baseRepo = path.join(__dirname, '../fixtures/repo')
+const baseRepo = pathJoin(__dirname, '../fixtures/repo')
 
 function createTempRepo (callback) {
   const date = Date.now().toString()
-  const path = `/tmp/bitswap-tests-${date}-${Math.random()}`
+  const path = pathJoin(os.tmpdir(), `bitswap-tests-${date}-${Math.random()}`)
 
   ncp(baseRepo, path, (err) => {
     if (err) { return callback(err) }
 
     const repo = new IPFSRepo(path)
 
-    repo.teardown = (callback) => rimraf(path, callback)
+    repo.teardown = (done) => {
+      series([
+        (cb) => repo.close(cb),
+        (cb) => rimraf(path, cb)
+      ], (err) => done(err))
+    }
 
     repo.open((err) => {
       if (err) { return callback(err) }

test/utils/make-block.js

@@ -4,9 +4,10 @@ const multihashing = require('multihashing-async')
 const CID = require('cids')
 const Block = require('ipfs-block')
 const Buffer = require('safe-buffer').Buffer
+const uuid = require('uuid/v4')
 
 module.exports = (callback) => {
-  const data = Buffer.from(`hello world ${Math.random()}`)
+  const data = Buffer.from(`hello world ${uuid()}`)
 
   multihashing(data, 'sha2-256', (err, hash) => {
     if (err) { return callback(err) }

test/wantmanager/index.spec.js

@@ -67,7 +67,7 @@ describe('WantManager', () => {
           expect(m[0]).to.be.eql(calls.connects[i])
           if (!m[1].equals(msgs[i])) {
             return done(
-              new Error(`expected ${m[1].toString()} to equal ${msgs[1].toString()}`)
+              new Error(`expected ${m[1].toString()} to equal ${msgs[i].toString()}`)
             )
           }
         })