Broken on Windows since interface-datastore use of os-specific path separators

[Expyron]

In commit d7ec65a, interface-datastore was changed to use os-specific path separators.

However, js-ipfs-repo is still hardcoded to use a slash (here, maybe other places). This throws an error here.

The specifications of interface-datastore should be clarified as to whether we should always use slashes or os-specific path separators, and either interface-datastore or js-ipfs-repo fixed in accordance with the specifications.

I can submit a pull-request depending on the decision.

[daviddias]

Ref: ipfs/js-ipfs#1017

[Expyron]

After some more checking, while this is easy to fix for the blockstore by simply normalizing the path, there is also the same issue in the datastore.

A datastore created on Windows will contain keys with backslashes. This means datastores created on Linux cannot be read on Windows, and conversely. Interop tests are failing on Windows because the test repo has (obviously) been created with slashes.

[richardschneider]

The datastore should be os-agnostic. All keys should use the same path separator of /. Only file storage implementations should worry about the os styled path conventions.

@pvh has raised ipfs/interface-datastore#11 which is a step in the correct direction.

[richardschneider]

I'm getting the following error when running the tests on windows

 1) IPFS Repo Tests on on Node.js default "before all" hook:
: The filename, directory name, or volume label syntax is incorrect.s-ipfs-repo\test\test-repo-for-1509616898591\datastore/MANIFEST-000052

      at c:\Users\Owner\Documents\GitHub\js-ipfs-repo\node_modules\levelup\lib\levelup.js:117:34
      at c:\Users\Owner\Documents\GitHub\js-ipfs-repo\node_modules\leveldown\node_modules\abstract-leveldown\abstract-leveldown.js:39:16

Looks like levelup needs some TLC for windows.

[daviddias]

Let's see how it behaves with the new datastores! => Track here: #146