feat: accept browser readable streams as input #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.b you can't read from a browser reaable stream repeatedly as the first call to `stream.getReader` locks the reader to the first invocation so I had to change all the test data to be functions that reutrn a new instance of the data.
achingbrain
requested review from
alanshaw and
hugomrdias
and removed request for
alanshaw
alanshaw
approved these changes
Jan 16, 2020
|
ping @hugomrdias when you get a sec! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.b you can't read from a browser readable stream repeatedly as the first call to
stream.getReaderlocks the reader to the first invocation so I had to change all the test data to be functions that return a new instance of the data.