fix: only try to initialize if not init already

Author: victorb

src/core/boot.js

@@ -47,25 +47,25 @@ module.exports = (self) => {
 
   const tasks = []
 
-  if (doInit) {
-    self.log('boot:doInit')
-    tasks.push((cb) => self.init(initOptions, cb))
-    next(null, true)
-  } else if (!repoOpen) {
-    self._repo.exists(next)
-  }
+  self._repo.exists((err, repoExists) => {
+    if (err) {
+      return done(err)
+    }
+    if (doInit && !repoExists) {
+      tasks.push((cb) => self.init(initOptions, cb))
+    }
+    if (repoExists) {
+      tasks.push(maybeOpenRepo)
+    }
+    next(null, repoExists)
+  })
 
   function next (err, hasRepo) {
     self.log('boot:next')
     if (err) {
       return done(err)
     }
 
-    if (hasRepo && !doInit) {
-      self.log('boot:maybeopenreop')
-      tasks.push(maybeOpenRepo)
-    }
-
     if (setConfig) {
       self.log('boot:setConfig')
       if (!hasRepo) {

test/core/create-node.spec.js

@@ -203,4 +203,19 @@ describe('create node', () => {
       (cb) => node.stop(cb)
     ], done)
   })
+
+  it('can start node twice without crash', (done) => {
+    const repo = createTempRepo()
+    let node = new IPFS({repo, config: {Bootstrap: []}})
+    series([
+      (cb) => node.once('start', cb),
+      (cb) => node.stop(cb),
+      (cb) => {
+        node = new IPFS({repo, config: {Bootstrap: []}})
+        node.on('error', cb)
+        node.once('start', cb)
+      },
+      (cb) => node.stop(cb)
+    ], done)
+  })
 })