Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Commit 9d4102e

Browse files
author
Alan Shaw
committed
chore: remove skips for ls tests
License: MIT Signed-off-by: Alan Shaw <[email protected]>
1 parent c021469 commit 9d4102e

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

test/core/interface.spec.js

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,7 @@ describe('interface-ipfs-core tests', function () {
6262
})
6363

6464
tests.filesRegular(defaultCommonFactory, {
65-
skip: isNode ? [{
66-
name: 'should ls with a base58 encoded CID',
67-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
68-
}, {
69-
name: 'should readable stream ls with a base58 encoded CID',
70-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
71-
}, {
72-
name: 'should pull stream ls with a base58 encoded CID',
73-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
74-
}] : [{
65+
skip: isNode ? null : [{
7566
name: 'addFromStream',
7667
reason: 'Not designed to run in the browser'
7768
}, {
@@ -80,15 +71,6 @@ describe('interface-ipfs-core tests', function () {
8071
}, {
8172
name: 'addFromURL',
8273
reason: 'Not designed to run in the browser'
83-
}, {
84-
name: 'should ls with a base58 encoded CID',
85-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
86-
}, {
87-
name: 'should readable stream ls with a base58 encoded CID',
88-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
89-
}, {
90-
name: 'should pull stream ls with a base58 encoded CID',
91-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
9274
}]
9375
})
9476

test/http-api/interface.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,7 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
4646
]
4747
})
4848

49-
tests.filesRegular(defaultCommonFactory, {
50-
skip: [{
51-
name: 'should ls with a base58 encoded CID',
52-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
53-
}, {
54-
name: 'should readable stream ls with a base58 encoded CID',
55-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
56-
}, {
57-
name: 'should pull stream ls with a base58 encoded CID',
58-
reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
59-
}]
60-
})
49+
tests.filesRegular(defaultCommonFactory)
6150

6251
tests.filesMFS(defaultCommonFactory)
6352

0 commit comments

Comments
 (0)