Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Upgrade to latest ipld-dag-cbor #1610

Closed
mikeal opened this issue Oct 2, 2018 · 2 comments
Closed

Upgrade to latest ipld-dag-cbor #1610

mikeal opened this issue Oct 2, 2018 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up

Comments

@mikeal
Copy link
Contributor

mikeal commented Oct 2, 2018

We made a pretty big change to the ipld-dag-cbor API.

Instead of using {"/": baseEncodedString} to express links we're just using CID instances.

This will probably end up simplifying a bunch of code in js-ipfs but it will be a pretty impactful change. For encoding, we still support the old form, so you only need to move to the new way once you find it necessary. But, there's a breaking change on the decoder side because all links are now CID instances.

The direct ipld-dag-cbor dep is barely used, it's mostly used by deps of deps:

├─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
├─┬ [email protected]
│ └── [email protected]
└── [email protected]

What's the best strategy for getting all the deps of the deps updated and into a release?

We don't want to release "ProtoSchool 1.0" until this changes is in a js-ipfs release. Link creation w/ ipfs.dag.put in IPFS is a big part of the basic tutorials and the new API is much nicer and easier to teach and we'd hate to teach people the old API and then change it a month later. But this also means that this dep upgrade will end up being a blocker for ProtoSchool if it lingers for too long.

@vmx
Copy link
Member

vmx commented Oct 5, 2018

I'm currently working on it. It seems easier than I thought, only flaky tests make it a bit harder.

@alanshaw alanshaw added exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Oct 17, 2018
@alanshaw
Copy link
Member

The direct dependency on ipld-dag-cbor was removed in #1626 and IPLD was upgraded to a version including the breaking API changes here #1668. This will be in the upcoming js-ipfs 0.33 release.

@ghost ghost removed the status/ready Ready to be worked label Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

3 participants