Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Test Failure: should add buffer bigger than Hapi default max bytes (1024 * 1024) #3169

Closed
Gozala opened this issue Jul 14, 2020 · 2 comments
Closed

Comments

@Gozala
Copy link
Contributor

Gozala commented Jul 14, 2020

I noticed that #3151 started to fail in CI following test:

it('should add buffer bigger than Hapi default max bytes (1024 * 1024)', async () => {
const payload = Buffer.from([
'',
'------------287032381131322',
'Content-Disposition: form-data; name="test"; filename="test.txt"',
'Content-Type: text/plain',
'',
randomBytes(1024 * 1024 * 2).toString('hex'),
'------------287032381131322--'
].join('\r\n'))
const res = await http({
method: 'POST',
url: '/api/v0/add',
headers: {
'Content-Type': 'multipart/form-data; boundary=----------287032381131322'
},
payload
}, { ipfs })
expect(res).to.have.property('statusCode', 200)
})

I could not reproduce that locally, until I did fresh npm install after which it started to fail. It appears to fail with current master as well. I'm guessing minor update of some library introduced this regression.

@achingbrain
Copy link
Member

This should be fixed now, please trigger a new build.

@jacobheun jacobheun added need/author-input Needs input from the original author and removed need/triage Needs initial labeling and prioritization labels Jul 16, 2020
@jacobheun
Copy link
Contributor

Please reopen if this is still a problem.

@jacobheun jacobheun removed the need/author-input Needs input from the original author label Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants