Skip to content

Add Pin.created? #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidel opened this issue Jul 16, 2020 · 2 comments
Closed

Add Pin.created? #33

lidel opened this issue Jul 16, 2020 · 2 comments
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase need/community-input Needs input from the wider community P3 Low: Not priority right now topic/pin/adding Issues related to pinning new stuff topic/pin/status-check Issues related to checking pin status

Comments

@lidel
Copy link
Member

lidel commented Jul 16, 2020

Knowing when the Pin object was created sounds useful and generic.
Filtering by creation date was raised in various conversations.

Q:

  • Should we add it as part of the mandatory spec?
    • Note: this does not impact WebUI integration, so not a blocker.
    • We won't include it, unless we hear feedback that it is needed
  • If we want to add it, what would be the mechanics of this field?
    • Proposal: Pin.created is optional during pin creation, if user does not pass a timestamp, Pinning Service will fill it with current time in UTC.
@lidel lidel added help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase need/community-input Needs input from the wider community topic/pin/adding Issues related to pinning new stuff topic/pin/status-check Issues related to checking pin status P3 Low: Not priority right now labels Jul 16, 2020
@andrew
Copy link

andrew commented Sep 22, 2020

I think this can be closed?

@lidel
Copy link
Member Author

lidel commented Sep 22, 2020

Yes, RFC version implemented in #39

@lidel lidel closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase need/community-input Needs input from the wider community P3 Low: Not priority right now topic/pin/adding Issues related to pinning new stuff topic/pin/status-check Issues related to checking pin status
Projects
None yet
Development

No branches or pull requests

2 participants