Merge pull request #5 from solo-io/api-pr

telemetry: update istio-api config

Author: douglas-reid

envoy/extensions/stats/config.pb.go

@@ -71,7 +71,6 @@ message MetricDefinition {
 }
 
 message PluginConfig {
-  // next id: 7
   // The following settings should be rarely used.
   // Enable debug for this filter.
   // DEPRECATED.
@@ -85,14 +84,14 @@ message PluginConfig {
 
   // prefix to add to stats emitted by the plugin.
   // DEPRECATED.
-  string stat_prefix = 3;  // default: "istio_"
+  string stat_prefix = 3; // default: "istio_"
 
   // Stats api squashes dimensions in a single string.
   // The squashed string is parsed at prometheus scrape time to recover
   // dimensions. The following 2 fields set the field and value separators {key:
   // value} -->  key{value_separator}value{field_separator}
-  string field_separator = 4;  // default: ";;"
-  string value_separator = 5;  // default: "=="
+  string field_separator = 4; // default: ";;"
+  string value_separator = 5; // default: "=="
 
   // Optional: Disable using host header as a fallback if destination service is
   // not available from the controlplane. Disable the fallback if the host
@@ -108,4 +107,28 @@ message PluginConfig {
 
   // Metric definitions.
   repeated MetricDefinition definitions = 9;
+
+  enum MetadataMode {
+    // Sidecar mode instructs the stats filter to pull local node information
+    // from the Envoy node metadata alone. This will be combined with peer
+    // metadata from Envoy filter state to build Istio service metrics.
+    SIDECAR_METADATA_MODE = 0;
+
+    // Ambient PEP mode instructs the stats filter to pull local node
+    // information host metadata provided by the control plane. This will be
+    // combined with peer metadata from Envoy filter state to build Istio
+    // service metrics.
+    AMBIENT_PEP_METADATA_MODE = 1;
+
+    // Potential other modes:
+    // - AMBIENT_UPROXY_METADATA_MODE
+
+    // next id: 2
+  }
+
+  // This will control how the stats filter discovers metadata for the workloads
+  // involved in a request / connection.
+  MetadataMode metadata_mode = 10;
+
+  // next id: 11
 }