Skip to content

Commit 545f4a8

Browse files
author
yingzhuivy
committed
istio-api: deprecate consecutive_errors and add gateway & 5xx errors
With the original consecutive_errors design, there is no way to turn off consecutive gateway errors. This CL deprecate the field and add two new fields: consecutive_gateway_errors and consecutive_5xx_errors. See discussions here: #909 Change-Id: I0e98990d194216cef842fb792a76a5f59b6e674e Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/199 Reviewed-by: Jungho Ahn <[email protected]> Reviewed-by: Weibo He <[email protected]>
1 parent 70ba402 commit 545f4a8

File tree

7 files changed

+477
-168
lines changed

7 files changed

+477
-168
lines changed

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 40 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.gen.json

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,20 @@
135135
"type": "string"
136136
},
137137
"consecutiveErrors": {
138-
"description": "Number of errors before a host is ejected from the connection pool. Defaults to 5. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as an error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as an error.",
138+
"description": "Number of errors before a host is ejected from the connection pool. Defaults to 5. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as an error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as an error. $hide_from_docs",
139139
"type": "integer",
140-
"format": "int32"
140+
"format": "int32",
141+
"deprecated": true
142+
},
143+
"consecutiveGatewayErrors": {
144+
"description": "Number of gateway errors before a host is ejected from the connection pool. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as an error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as a gateway error. If set to 0, this feature is disabled. Defaults to 5.",
145+
"type": "integer",
146+
"nullable": true
147+
},
148+
"consecutive5xxErrors": {
149+
"description": "Number of 5xx errors before a host is ejected from the connection pool. When the upstream host is accessed over TCP, errors are internally mapped to HTTP 5xx codes and treated as such. If set to 0, this feature is disabled. Defaults to 0. consecutive_gateway_errors and consecutive_5xx_errors can be used separately or together. The errors counted by consecutive_gateway_errors are also included in consecutive_5xx_errors, so consecutive_gateway_errors should be less than consecutive_5xx_errors when both are used.",
150+
"type": "integer",
151+
"nullable": true
141152
},
142153
"baseEjectionTime": {
143154
"description": "Minimum ejection duration. A host will remain ejected for a period equal to the product of minimum ejection duration and the number of times the host has been ejected. This technique allows the system to automatically increase the ejection period for unhealthy upstream servers. format: 1h/1m/1s/1ms. MUST BE \u003e=1ms. Default is 30s.",

0 commit comments

Comments
 (0)