deprecate consecutive_errors and add consecutive_gateway_errors & consecutive_5xx_errors (#1189)

* istio-api: add consecutive_5xx_errors for outlier detection

This CL adds consecutive_5xx_errors field in OutlierDetection.
This field describes the number of 5xx errors before a host is
ejected from the connection pool.

I made changes to destination_rule.proto, the other files are auto-generated.

Change-Id: Ib5097b3c6bf3ea2b8b2f857491537acb674ae1ff
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/195
Reviewed-by: Brian Wolfe <[email protected]>
Reviewed-by: Jungho Ahn <[email protected]>
Reviewed-by: Weibo He <[email protected]>

* Revert "istio-api: add consecutive_5xx_errors for outlier detection"

This reverts commit 064b737.

Reason for revert: decided to deprecate consecutive_errors

Change-Id: I95e3191db30711b1ce7abdebe7639de4899f2ab1
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/163
Reviewed-by: Jungho Ahn <[email protected]>

* istio-api: deprecate consecutive_errors and add gateway & 5xx errors

With the original consecutive_errors design, there is no way to turn
off consecutive gateway errors. This CL deprecate the field and add two
new fields: consecutive_gateway_errors and consecutive_5xx_errors.

See discussions here: #909

Change-Id: I0e98990d194216cef842fb792a76a5f59b6e674e
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/199
Reviewed-by: Jungho Ahn <[email protected]>
Reviewed-by: Weibo He <[email protected]>

* istio-api: consecutive 5xx defaults to 5, gateway defaults to 0

This CL changes the description of consecutive_5xx_errors and
consecutive_gateway errors. 5xx defaults to 5 and gateway defaults to 0.

Change-Id: I6c3b29cf92df1c972a7850a726eb159b5e23bf90
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/211
Reviewed-by: Jungho Ahn <[email protected]>

* istio-api: reword consecutive 5xx & gateway descriptions

This CL rewords the descriptions of consecutive 5xx & gateway as
suggected in https://github.com/istio/api/pull/1189/files.

Change-Id: Ia95c03da78a2c9f12c8762b9d8fb95e7add08516
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/214
Reviewed-by: Jungho Ahn <[email protected]>

Author: Ying Zhu

kubernetes/customresourcedefinitions.gen.yaml

@@ -135,9 +135,20 @@
             "type": "string"
           },
           "consecutiveErrors": {
-            "description": "Number of errors before a host is ejected from the connection pool. Defaults to 5. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as an error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as an error.",
+            "description": "Number of errors before a host is ejected from the connection pool. Defaults to 5. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as an error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as an error. $hide_from_docs",
             "type": "integer",
-            "format": "int32"
+            "format": "int32",
+            "deprecated": true
+          },
+          "consecutiveGatewayErrors": {
+            "description": "Number of gateway errors before a host is ejected from the connection pool. When the upstream host is accessed over HTTP, a 502, 503, or 504 return code qualifies as a gateway error. When the upstream host is accessed over an opaque TCP connection, connect timeouts and connection error/failure events qualify as a gateway error. This feature is disabled by default or when set to the value 0.",
+            "type": "integer",
+            "nullable": true
+          },
+          "consecutive5xxErrors": {
+            "description": "Number of 5xx errors before a host is ejected from the connection pool. When the upstream host is accessed over an opaque TCP connection, connect timeouts, connection error/failure and request failure events qualify as a 5xx error. This feature defaults to 5 but can be disabled by setting the value to 0.",
+            "type": "integer",
+            "nullable": true
           },
           "baseEjectionTime": {
             "description": "Minimum ejection duration. A host will remain ejected for a period equal to the product of minimum ejection duration and the number of times the host has been ejected. This technique allows the system to automatically increase the ejection period for unhealthy upstream servers. format: 1h/1m/1s/1ms. MUST BE \u003e=1ms. Default is 30s.",