Skip to content

cmd: --to-cache/remote updates (add, import-url, update) #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
isidentical opened this issue Jan 28, 2021 · 7 comments
Closed
5 of 6 tasks

cmd: --to-cache/remote updates (add, import-url, update) #2121

isidentical opened this issue Jan 28, 2021 · 7 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@isidentical
Copy link
Contributor

isidentical commented Jan 28, 2021

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions 2.0 release labels Jan 28, 2021
@isidentical isidentical self-assigned this Feb 5, 2021
@jorgeorpinel jorgeorpinel changed the title add, import-url, update: adapting docs to straight-to-* changes cmd: --to-cache/remote updates (add, import-url, update) Feb 5, 2021
@jorgeorpinel jorgeorpinel added the ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement label Feb 22, 2021
@jorgeorpinel
Copy link
Contributor

mention about --to-remote in https://dvc.org/doc/user-guide/managing-external-data

No need as we have a big ticket to rewrite that whole thing. But I did add another checkbox per #2175 (review) 👍

@dberenbaum
Copy link
Contributor

mention about --to-remote in https://dvc.org/doc/user-guide/managing-external-data

No need as we have a big ticket to rewrite that whole thing. But I did add another checkbox per #2175 (review) 👍

So what is the plan with https://dvc.org/doc/user-guide/managing-external-data for now? I think we have agreed that it's not worth re-writing for 2.0, since we need to change the functionality anyway, probably for 3.0. So that leaves us with some suboptimal choices:

  • Keep it as is
  • Drop it completely
  • Find ways to further discourage users from relying on it (remove or replace links to it, find a way to make the warning at the top even more prominent, etc.)

@jorgeorpinel
Copy link
Contributor

Unassigned @isidentical since the only thing left is to differentiate the to-remote exampled in add vs import-url, which we should be able to do (that said feel free to contribute a draft @isidentical).

what is the plan with https://dvc.org/doc/user-guide/managing-external-data

@dberenbaum please check/repost in #520 🙂

@iesahin iesahin removed the dvc label Oct 14, 2021
@iesahin iesahin added the C: ref Content of /doc/*-reference label Oct 21, 2021
@jorgeorpinel jorgeorpinel removed the ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement label Jan 14, 2022
@jorgeorpinel
Copy link
Contributor

Removed epic label since only one task is pending. WDYT about the remaining check box @dberenbaum ? Thanks

@dberenbaum
Copy link
Contributor

Are add --to-remote and import-url --to-remote that different? It seems the main difference is whether the user needs to track updates to that source location, but that's more about import-url generally than anything specific to --to-remote. I don't see the need to prioritize this checkbox unless it's about explaining --to-remote differently in both add and import-url.

Maybe @shcheklein has some idea since I think this was his comment?

@shcheklein
Copy link
Member

To be honest it's hard to restore the whole context now :) (partially that's why it's better to address certain issues earlier if possible - after that it takes time from a lot of people to read it again and restore the context). It's fine to skip it now I think. Probably I had in mind some general improvements to both intros to make them more explicit and simpler to read. I don't my suggestion though at the moment- it needs more time.

Jorge, you had initially concern that those two are completely different. To some extent they are, but intros phrases correct at the moment - import vs add, etc. So they are already different if you familiar with DVC terminology - what import does, what add does, etc.

WDYT?

@jorgeorpinel jorgeorpinel changed the title cmd: --to-cache/remote updates (add, import-url, update) cmd: --to-cache/remote updates (add, import-url, update) Jan 20, 2022
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 20, 2022

the main difference is whether the user needs to track updates to that source location

This is the only difference technically, yes (extra info. in the "import .dvc file").

you had initially concern that those two are completely different

Initially I argued that we only need the option in import-url but keeping it in add too was decided because "they're different operations", so I was trying to reflect that in docs.

better to address certain issues earlier if possible

Sometimes letting time pass helps get perspective though. I think we were not understanding each other well before. I see value in having the option in both places now, even if it's just for discoverability (since add is much more used than import). I guess that was your argument and no that they're different use cases (what I understood).

So I'll close this and just review that the language is consistent and that each command semantics are preserved in both examples. Another strategy could be to only keep the example in import-url and link to it from the add --to-remote option. Let's decide on the PR (I'll tag you).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

5 participants