Skip to content

Commit 8154c89

Browse files
committed
tests: remove redundant native ssh tests
We already have mocked ones, which are more reliable as they use their own paramiko server instead of relying on the sshd running on the test machine. Native tests are also quite flaky and fail sometimes due to network issues.
1 parent 0110358 commit 8154c89

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

tests/func/test_data_cloud.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
from tests.remotes import (
3434
_should_test_gcp,
3535
_should_test_hdfs,
36-
_should_test_ssh,
3736
Azure,
3837
GDrive,
3938
S3,
@@ -47,7 +46,6 @@
4746
get_gcp_url,
4847
get_hdfs_url,
4948
get_local_url,
50-
get_ssh_url,
5149
get_ssh_url_mocked,
5250
)
5351

@@ -296,17 +294,6 @@ def test(self):
296294
self.assertTrue(os.path.isdir(self.dname))
297295

298296

299-
class TestRemoteSSH(TestDataCloudBase):
300-
def _should_test(self):
301-
return _should_test_ssh()
302-
303-
def _get_url(self):
304-
return get_ssh_url()
305-
306-
def _get_cloud_class(self):
307-
return RemoteSSH
308-
309-
310297
@pytest.mark.usefixtures("ssh_server")
311298
class TestRemoteSSHMocked(TestDataCloudBase):
312299
@pytest.fixture(autouse=True)
@@ -442,18 +429,6 @@ def _test(self):
442429
self._test_cloud(TEST_REMOTE)
443430

444431

445-
class TestRemoteSSHCLI(TestDataCloudCLIBase):
446-
def _should_test(self):
447-
return _should_test_ssh()
448-
449-
def _test(self):
450-
url = get_ssh_url()
451-
452-
self.main(["remote", "add", TEST_REMOTE, url])
453-
454-
self._test_cloud(TEST_REMOTE)
455-
456-
457432
class TestRemoteHDFSCLI(TestDataCloudCLIBase):
458433
def _should_test(self):
459434
return _should_test_hdfs()

0 commit comments

Comments
 (0)