Skip to content

run: support --non-deterministic #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efiop opened this issue Nov 28, 2018 · 5 comments
Closed

run: support --non-deterministic #1379

efiop opened this issue Nov 28, 2018 · 5 comments
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Milestone
Queue

Comments

@efiop
Copy link
Contributor

efiop commented Nov 28, 2018

This flag should mark dvc file as:

deterministic: False

and dvc repro should always reproduce it.
@efiop efiop assigned efiop and unassigned efiop Nov 28, 2018
@efiop efiop added the enhancement Enhances DVC label Nov 28, 2018
@efiop efiop added this to the Queue milestone Nov 28, 2018
@prihoda
Copy link
Contributor

prihoda commented Nov 29, 2018

Why not call it something like --always-reproduce, so that it can be used in other contexts?

@efiop
Copy link
Contributor Author

efiop commented Nov 29, 2018

@prihoda That is a actually a great name suggestion :) We'll use it instead. Thank you!

@prihoda
Copy link
Contributor

prihoda commented Dec 4, 2018

I'm wondering, how about we discard callback stages and support that behavior with --always-reproduce? Personally, I don't see the causality in the "no dependencies" => "always reproduce" behavior.

@efiop efiop mentioned this issue Dec 4, 2018
Closed
@efiop
Copy link
Contributor Author

efiop commented Dec 4, 2018

@prihoda I agree, --always-reproduce is a much nicer way of achieving that callback behavior. I think we could abandon it in the 1.0. Created #1407 . Thanks! 🙂

@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Jul 23, 2019
@efiop
Copy link
Contributor Author

efiop commented Dec 7, 2020

We now have --always-changed flag for dvc run. Closing this in favor of #1407

@efiop efiop closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Projects
None yet
Milestone
Queue
Development

No branches or pull requests
2 participants
@prihoda @efiop