Skip to content

Use mock instead of HTTPServer #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pared opened this issue Feb 4, 2019 · 3 comments
Closed

Use mock instead of HTTPServer #1573

pared opened this issue Feb 4, 2019 · 3 comments
Labels
enhancement Enhances DVC

Comments

@pared
Copy link
Contributor

pared commented Feb 4, 2019

For functional tests we use tests.utils.httpd.StaticFileServer. To prevent mess associated with multiple tests trying to use server, we would prefer to use something that could mock responses, like https://github.com/bblimke/webmock (proposed by @shcheklein in #1540).
Task:
Remove StaticFileServer, use mocks instead.

@efiop
Copy link
Contributor

efiop commented Feb 4, 2019

@pared we could have both. The current one is suitable for functional tests, and mocked one would be suitable for unit tests. We will introduce a requirement for 100% coverage by unit tests in the future, so that is where mocked server could be used to quickly and efficiently test PRs, so then we could have a cron job or master tests to run functional tests.

@ghost ghost added the enhancement Enhances DVC label Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

Some how related: #907

@efiop
Copy link
Contributor

efiop commented Feb 5, 2019

Closing in favor of #907

@efiop efiop closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

No branches or pull requests

2 participants