Skip to content

dvc add is not atomic command #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmpetrov opened this issue Feb 20, 2019 · 0 comments
Closed

dvc add is not atomic command #1641

dmpetrov opened this issue Feb 20, 2019 · 0 comments
Assignees
@pared
Labels
enhancement Enhances DVC

Comments

@dmpetrov
Copy link
Member

If dvc add fails it keeps new created .gitignore. See repro script from #1640.

DVC have to revert all the changes after failing command or output warning if it is not possible.
@dmpetrov dmpetrov added the enhancement Enhances DVC label Feb 20, 2019
@pared pared self-assigned this Feb 27, 2019
@pared pared mentioned this issue Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmpetrov @pared