Skip to content

import: use explicit field in dvcfile #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efiop opened this issue Apr 4, 2019 · 5 comments
Closed

import: use explicit field in dvcfile #1830

efiop opened this issue Apr 4, 2019 · 5 comments
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Milestone
Incompatible

Comments

@efiop
Copy link
Contributor

efiop commented Apr 4, 2019

Currently if we have no command, 1 dependency and 1 output in the dvcfile, we assume that it is dvc import. This approach has drawbacks as described in #1401 . It would be better to set an explicit field import: true in dvcfile. This could be either implemented in 1.0 by breaking backward compatibility, or earlier by setting import: false by default.
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Apr 4, 2019
@efiop efiop added this to the 1.0.0 milestone Apr 4, 2019
@efiop efiop added the enhancement Enhances DVC label Apr 4, 2019
@efiop efiop mentioned this issue Apr 4, 2019
Closed
@efiop
Copy link
Contributor Author

efiop commented Apr 4, 2019

Related to implicit behaviour we have in #1407

@jorgeorpinel
Copy link
Contributor

Hi, is this still a relevant issue? I think the import stages have a repo, rev_lock, and sometimes rev fields now.

@efiop
Copy link
Contributor Author

efiop commented Feb 11, 2020

@jorgeorpinel It is. dvc import-url don't have those and import still sufferers from the issues described above.

@dberenbaum
Copy link
Contributor

Is this still a concern @efiop?

@efiop
Copy link
Contributor Author

efiop commented Jun 20, 2022

Yes, but let's close as stale, because we'll never remember that this issue existed 🙂

@efiop efiop closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Projects
None yet
Milestone
Incompatible
Development

No branches or pull requests
3 participants
@jorgeorpinel @dberenbaum @efiop