Skip to content

make status take .dvcignore into account #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pared opened this issue Apr 5, 2019 · 7 comments
Closed

make status take .dvcignore into account #1834

pared opened this issue Apr 5, 2019 · 7 comments
Labels
enhancement Enhances DVC

Comments

@pared
Copy link
Contributor

pared commented Apr 5, 2019

After merging #1499 user might want to ignore some files. Add functionality to dvc status, that will allow user verify if his .dvcignore works as intended.
E.g.: when using git, git status shows all files in repository that are not ignored. There is no such straightforward command in dvc.

@ghost ghost added the enhancement Enhances DVC label Apr 6, 2019
@shcheklein
Copy link
Member

@pared will this one be closed as well soon?

@pared
Copy link
Contributor Author

pared commented Jun 26, 2019

@shcheklein
Yes, now every use case of walk in our codebase will take .dvcignore into account (besides some tests)

@pared
Copy link
Contributor Author

pared commented Jul 15, 2019

@efiop I think we need to reopen it, or open new issue. The title of this issue is about something different than description, thats my fault. While status take .dvcignore into account while traversing now, we still need some easy way to show user that .dvcignore is working, as intended.

@efiop
Copy link
Contributor

efiop commented Jul 15, 2019

@pared Aah, got it. I've seen it listed as Fixes #1876 #1834 in #2161 and so thought that it just wasn't closed accidentally. Ok, reopenning. But do we actually need it though? Git doesn't show the files it ignores, why should we?

@efiop efiop reopened this Jul 15, 2019
@pared
Copy link
Contributor Author

pared commented Jul 15, 2019

@efiop thats my bad, sorry.
Well, there is indirect way of detecting ignores, when you use git status and you don't see ignored files. Our status does not work the same way as git does so there is not even indirect way of doing it.

@efiop
Copy link
Contributor

efiop commented Jul 15, 2019

@pared Well, but if it is not ignored by us, then git status will show those files, no? I don't quite understand what functionality from dvc status do you expect. Maybe you could provide an example?

@pared
Copy link
Contributor Author

pared commented Jul 16, 2019

@efiop, ok, now that I started to think about example, i doubt we need to implement some feature, indicating that something is ignored.
If someone has data dir, and ignores something inside, status will show it changed, and that is important.

I was thinking about some command that would display all ignored files, but now I don't think it is necessary (at least until someone asks for it with proper reasoning). We can re-close it, sorry.

@efiop efiop closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

No branches or pull requests

3 participants