Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

reducing confusion between dvc remote and git remote #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skshetry opened this issue Jun 2, 2020 · 6 comments
Closed

reducing confusion between dvc remote and git remote #3937

skshetry opened this issue Jun 2, 2020 · 6 comments
Labels
discussion requires active participation to reach a conclusion

Comments

@skshetry
Copy link
Collaborator

skshetry commented Jun 2, 2020

I have seen too many people getting confused over dvc vs git remote.

Looks like this should be handled by dvc after all.

We could either:

  1. Change terminology from remote to storage or cache, similarly change commands:
dvc storage add s3 s3://bucket/

We can keep using remote as an alias.

  1. Try to see if the remote url is a git remote based on heuristics (eg: if domain name is github for example) and thrown a error and a hint for what to do.

... More ideas?

cc @jorgeorpinel

@skshetry skshetry added the discussion requires active participation to reach a conclusion label Jun 2, 2020
@shcheklein
Copy link
Member

It's a good one. The only thing to keep in mind that we use our "remotes" not only as storages - e.g. remote:// notation for external deps/outs.

@skshetry
Copy link
Collaborator Author

skshetry commented Jun 3, 2020

storage:// make more sense to me as well. Again, we can keep remote:// as an alias if we don't want to break compatibility.

$ dvc add storage://dvc-test/123

@efiop
Copy link
Contributor

efiop commented Jun 3, 2020

How would the other commands look like? E.g. push/pull?

dvc push --storage mys3

?

Should we change the terminology for the .dvc/cache too?

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Jun 4, 2020
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 6, 2020

Change terminology from remote to storage... keep using remote as an alias

➕1️⃣ !!! I would maybe just use the term "cache storage" sometimes in key places of the docs.

dvc push --storage mys3

@efiop -s/--storage should work, yes.

change the terminology for the .dvc/cache too?

What do you mean? As in .dvc/storage? I think that's a separate question, could be considered but term "cache" isn't a source of confusion AFAI. Again, I think we can associate the concepts effectively in key docs.

@efiop
Copy link
Contributor

efiop commented Jun 8, 2020

$ dvc add storage://dvc-test/123

@skshetry Btw, this doesn't look very good. See #3920 , it feels like this use case is a "workspace" case. And this might be where storage might be confusing, as it is too ambiguous, whereas remote is a storage in dvc-specific format (our cache format), which is similar to git remotes.

@efiop
Copy link
Contributor

efiop commented Jun 8, 2020

What do you mean? As in .dvc/storage? I think that's a separate question, could be considered but term "cache" isn't a source of confusion AFAI. Again, I think we can associate the concepts effectively in key docs.

@jorgeorpinel We have actually heard questions about it too 🙂 It is really closer to .git/objects.

@efiop efiop removed the awaiting response we are waiting for your reply, please respond! :) label Jul 21, 2020
@efiop efiop closed this as completed May 3, 2021
@iterative iterative locked and limited conversation to collaborators May 3, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
discussion requires active participation to reach a conclusion
Projects
None yet
Development

No branches or pull requests

4 participants