Skip to content

rename .dvc file to .lock file #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skshetry opened this issue Jun 30, 2020 · 3 comments
Closed

rename .dvc file to .lock file #4132

skshetry opened this issue Jun 30, 2020 · 3 comments
Labels
awaiting response we are waiting for your reply, please respond! :)

Comments

@skshetry
Copy link
Collaborator

skshetry commented Jun 30, 2020

We have two concepts now: .dvc file and .lock file. It'd be good to have consistent set of files: dvc.lock and dvc.yaml. The files could be named .lock (it could collide with other .lock files eg: Pipfile.lock, etc. so maybe .dvc.lock).

@ghost ghost added the triage Needs to be triaged label Jun 30, 2020
@efiop
Copy link
Contributor

efiop commented Jun 30, 2020

.lock is a temporary file that we can live without, which is not the case for dvc added and dvc imported files right now. But even just when talking about renaming, .dvc.lock is the only option that is visually identifiable as something that belongs to dvc, at which point it is not clear why we would just make the suffix longer with no clear benefit. And right now .dvc belongs to data management, while dvc.yaml and dvc.lock to pipelines, which are useful to separate from each other.

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Jun 30, 2020
@ghost ghost removed the triage Needs to be triaged label Jun 30, 2020
@skshetry
Copy link
Collaborator Author

Having a single kind of format would be better to explain others conceptually. And, dvc.lock and .dvc files are the same thing with different file extension. Though, I did forget that it'd collide with other .lock files when making this issue.

@efiop
Copy link
Contributor

efiop commented Jun 30, 2020

@skshetry Actually they are not the same thing even anymore. E.g. .lock is multistage, but .dvc isn't. And the differences will be bigger and bigger as we go, as we are no longer limited by them (dvc run and dvc add .dvc-files) being the same thing. We used to have that in 0.x as you remember, and even though it was nice that it was the same format, but it was actually confusing in the real world, as data management and pipeline management didn't mix together nicely and we always had to explain all the corner cases (e.g. dvc add is a corner case of dvc run with no command, no deps), hence why we've moved to the current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :)
Projects
None yet
Development

No branches or pull requests

2 participants