Skip to content

status: change "changed checksum" state to "changed command" #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorgeorpinel opened this issue Jul 10, 2020 · 4 comments
Closed

status: change "changed checksum" state to "changed command" #4189

jorgeorpinel opened this issue Jul 10, 2020 · 4 comments
Labels
awaiting response we are waiting for your reply, please respond! :)

Comments

@jorgeorpinel
Copy link
Contributor

Report

Extracted from iterative/dvc.org#1384 (review)

The changed checksum status (which only applies to .dvc files, mostly for backward compatibility purposes) should be called something else probably, maybe changed command. Something that reflects better what the change or state is.

Please provide information about your setup

DVC 1.1

@jorgeorpinel
Copy link
Contributor Author

P/s addressing this will imply a small change to the status cmd ref in the docs.

@efiop
Copy link
Contributor

efiop commented Jul 10, 2020

The changed checksum status (which only applies to .dvc files, mostly for backward compatibility purposes) should be called something else probably, maybe changed command. Something that reflects better what the change or state is.

There is no command in .dvc files created by add and import[-url]. So current changed checksum still makes sense. 🙂

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Jul 10, 2020
@ghost ghost removed the triage Needs to be triaged label Jul 10, 2020
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 11, 2020

OK. But .dvc files no longer store their own checksums, right?

Also, the term we use now is "file hash" (or sometimes "hash value" to avoid repeating the word "file" depending on the context). checksum was deemed inaccurate, and refers only to HDFS external deps/outs now.

P/s I opened this issue per your iterative/dvc.org#1384 (comment), Ruslan 🙂 so up to you if you want to close it.

@efiop
Copy link
Contributor

efiop commented Jul 11, 2020

OK. But .dvc files no longer store their own checksums, right?

dvc import[-url]ed do store checksums.

Also, the term we use now is "file hash" (or sometimes "hash value" to avoid repeating the word "file" depending on the context). checksum was deemed inaccurate, and refers only to HDFS external deps/outs now.

Yeah, this is a bigger issue all over the code. It will be solved gradually.

P/s I opened this issue per your iterative/dvc.org#1384 (comment), Ruslan slightly_smiling_face so up to you if you want to close it.

Thanks! Closing since the terminology is correct here (with exception of checksum, but that is to be solved in the future just gradually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :)
Projects
None yet
Development

No branches or pull requests

2 participants