Skip to content

dvc add: .dvcignore example not working as expected [qa] #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkarshsingh99 opened this issue Jul 12, 2020 · 3 comments · Fixed by #4125
Closed

dvc add: .dvcignore example not working as expected [qa] #4197

utkarshsingh99 opened this issue Jul 12, 2020 · 3 comments · Fixed by #4125
Assignees
Labels
bug Did we break something?

Comments

@utkarshsingh99
Copy link

Screenshot from 2020-07-13 00-44-27

I was following this example and it does detect changes in the file in dvc.

DVC Version: 1.1.9 (virtualenv)

I'm not sure if this is a bug in the .dvcignore feature of DVC itself, or rather just a mistake on my part. Thus, opening the issue here and not in the orig DVC repo.

P.S.: The dir/file1 already had its content as file_one_changed and that's why there is no change detected in the first dvc status command

@shcheklein shcheklein transferred this issue from iterative/dvc.org Jul 12, 2020
@ghost ghost added the triage Needs to be triaged label Jul 12, 2020
@shcheklein
Copy link
Member

@pared could you take a look and confirm is it an example or DVC core problem?

@efiop efiop added bug Did we break something? p0-critical labels Jul 12, 2020
@ghost ghost removed triage Needs to be triaged labels Jul 12, 2020
@pared
Copy link
Contributor

pared commented Jul 13, 2020

So the problem of file1 getting added to cache, even though it is ignored is related to: #4110 and #4125.
Taking care of it.

@pared pared self-assigned this Jul 13, 2020
@jorgeorpinel jorgeorpinel changed the title dvc add: .dvcignore example not working as expected dvc add: .dvcignore example not working as expected [qa] Jul 13, 2020
@pared
Copy link
Contributor

pared commented Jul 17, 2020

@utkarshsingh99 The fix for this issue has been merged. New release should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants