Skip to content

import-url --file=something.yaml ... doesn't save stage anywhere #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Suor opened this issue Jul 19, 2020 · 6 comments
Closed

import-url --file=something.yaml ... doesn't save stage anywhere #4239

Suor opened this issue Jul 19, 2020 · 6 comments
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important

Comments

@Suor
Copy link
Contributor

Suor commented Jul 19, 2020 •
edited
Loading

The underlying issue is PipelineFile.dump() having unsafe design and breaking polymorphism. Here the suffix of the --file determines what class will be used as Dvcfile and while SingleStageFile.dump() indeed dumps the stage, PipelineFile.dump() does not by default.

This issue caused #3907 and was explained there in more detail. It may cause other undiscovered and future issues.
@ghost ghost added the triage Needs to be triaged label Jul 19, 2020
@Suor Suor added the bug Did we break something? label Jul 19, 2020
@ghost ghost removed the triage Needs to be triaged label Jul 19, 2020
@skshetry
Copy link
Collaborator

@Suor, import stages are not supported for dvc.yaml.

@Suor
Copy link
Contributor Author

Suor commented Jul 19, 2020 •
edited
Loading

Nothing stops me from trying though, dvc will act surprisingly.

And I spend 10 minutes to find this, there are probably more. Until PipelineFile.dump() is fixed this will continue.

@efiop efiop added the p1-important Important, aka current backlog of things to do label Jul 19, 2020
@weekly-digest weekly-digest bot mentioned this issue Jul 26, 2020
Closed
@karajan1001
Copy link
Contributor

So why there are two kinds of dvcfile ? Compatible with the older version?

@efiop
Copy link
Contributor

efiop commented Sep 21, 2020

@karajan1001 Sorry for the delay. Correct, we are using dvc.yaml for pipelines and *.dvc for dvc add/import/import-url.

@dberenbaum dberenbaum removed the p1-important Important, aka current backlog of things to do label Feb 18, 2022
@dberenbaum
Copy link
Contributor

@Suor @efiop Is this still an issue? For now, I'm lowering the priority to p2.

@efiop efiop added the p2-medium Medium priority, should be done, but less important label Apr 6, 2022
@efiop
Copy link
Contributor

efiop commented Dec 8, 2023

Closing as stale.

@efiop efiop closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Suor @dberenbaum @efiop @karajan1001 @skshetry