Fix filename selector matching Windows filenames

- Fix filename matching to use os.sep
- Add Appveyor builds

Author: jayvdb

.appveyor.yml

@@ -0,0 +1,27 @@
+environment:
+  matrix:
+    - PYTHON: "C:\\Python27"
+      APPVEYOR_PYTHON_VERSION: "2.7.x" # currently 2.7.11
+
+    - PYTHON: "C:\\Python34"
+      APPVEYOR_PYTHON_VERSION: "3.4.x" # currently 3.4.3
+
+init:
+  - "SET PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%"
+  - "ECHO PATH=%PATH%"
+  - python --version
+
+build: off
+
+install:
+  - pip install tox wheel
+
+test_script:
+  - tox -e pytest
+  - tox -e flakes-v250,flakes-v241,flakes-v230,flakes-v224,flakes-v220
+
+deploy_script:
+  - python setup.py sdist bdist_wheel
+
+artifacts:
+  - path: dist\* .coverage coverage.xml

flake8_putty/config.py

@@ -12,6 +12,8 @@
 except ImportError:
     markers = None
 
+IS_WINDOWS = (sys.platform == 'win32')
+
 SELECTOR_SPLITTER = re.compile(r' *(/.*?(?<!\\)/|[^/][^,]*) *,?')
 
 ENVIRONMENT_MARKER_PREFIXES = (
@@ -236,7 +238,10 @@ def __eq__(self, other):
     def file_match_any(self, filename):
         """Match any filename."""
         if filename.startswith('.' + os.sep):
-            filename = filename[2:]
+            filename = filename[len(os.sep) + 1:]
+        if os.sep != '/':
+            filename = filename.replace(os.sep, '/')
+
         for selector in self.file_selectors:
             if (selector.pattern.endswith('/') and
                     filename.startswith(selector.pattern)):

tests/test_config.py

@@ -2,6 +2,8 @@
 """Test config parser."""
 from __future__ import unicode_literals
 
+import os
+
 from unittest import TestCase
 
 from flake8_putty.config import (
@@ -258,7 +260,7 @@ class TestMatch(TestCase):
     def test_selector_filename(self):
         p = Parser('foo.py : E101')
         assert p._rules[0].file_match_any('foo.py')
-        assert p._rules[0].file_match_any('./foo.py')
+        assert p._rules[0].file_match_any('.{0}foo.py'.format(os.sep))
         assert not p._rules[0].file_match_any('bar.py')
         assert not p._rules[0].file_match_any('foo/bar.py')
 
@@ -270,7 +272,7 @@ def test_selector_filename_missing(self):
     def test_selector_filename_multi(self):
         p = Parser('foo.py, bar.py : E101')
         assert p._rules[0].file_match_any('foo.py')
-        assert p._rules[0].file_match_any('./foo.py')
+        assert p._rules[0].file_match_any('.{0}foo.py'.format(os.sep))
         assert p._rules[0].file_match_any('bar.py')
         assert not p._rules[0].file_match_any('foo/bar.py')
 
@@ -295,7 +297,9 @@ def test_selector_directory_multi(self):
     def test_selector_directory_wildcard(self):
         p = Parser('tests/*/test_*.py : E101')
         assert p._rules[0].file_match_any('tests/foo/test_bar.py')
-        assert p._rules[0].file_match_any('./tests/foo/bar/test_baz.py')
+        assert p._rules[0].file_match_any(
+            '.{0}tests/foo/bar/test_baz.py'.format(os.sep),
+        )
         assert p._rules[0].file_match_any('tests/foo/bar/test_.py')
         assert not p._rules[0].file_match_any('tests/test_foo.py')
 

tox.ini

@@ -3,7 +3,13 @@ skip_missing_interpreters = True
 envlist = flakes-v{250,241,230,224,220},green,pytest,test
 
 [testenv]
-passenv = CI TRAVIS_BUILD_ID TRAVIS TRAVIS_BRANCH TRAVIS_JOB_NUMBER TRAVIS_PULL_REQUEST TRAVIS_JOB_ID TRAVIS_REPO_SLUG TRAVIS_COMMIT
+passenv =
+    CI
+    TRAVIS TRAVIS_BUILD_ID TRAVIS_BRANCH TRAVIS_JOB_NUMBER TRAVIS_PULL_REQUEST
+    TRAVIS_JOB_ID TRAVIS_REPO_SLUG TRAVIS_COMMIT
+    APPVEYOR APPVEYOR_ACCOUNT_NAME APPVEYOR_PROJECT_SLUG APPVEYOR_REPO_NAME
+    APPVEYOR_REPO_COMMIT APPVEYOR_REPO_BRANCH APPVEYOR_BUILD_VERSION
+    APPVEYOR_JOB_ID APPVEYOR_PULL_REQUEST_NUMBER
 commands =
     flakes: flake8 --version
     flakes: flake8  {posargs}
@@ -40,7 +46,8 @@ deps =
     v250,v241: hacking
     v250,v241: flake8-coding
     v250,v241: flake8-tuple
-    v250,v241: flake8-mock
+    # https://github.com/aleGpereira/flake8-mock/issues/3
+    v250,v241: flake8-mock ; sys_platform != 'win32' or python_version < '3'
     v250,v241: flake8-dodgy
     v250,v241: flake8-tidy-imports
     v250,v241: flake8-import-order  # hacking has a similar rule
@@ -50,7 +57,9 @@ deps =
     # The following are run in a different toxenv,
     # as they are similar to one of the above plugins
     v230,v224: flake8-blind-except  # hacking has a similar rule
-    v230,v224: flake8-isort  # similar to flake8-import-order
+    # isort uses customised rules in setup.cfg to behave like flake8-import-order
+    # https://github.com/timothycrosley/isort/issues/419
+    v230,v224: flake8-isort ; sys_platform != 'win32'
     v230,v224: flake8-future ; python_version > '2.6'  # similar to flake8-future-import
     v230,v224: git+https://github.com/jayvdb/flake8-future@py26 ; python_version < '2.7'