Make providing region as optional

Author: msmygit

cassandra/cluster.py

@@ -40,6 +40,7 @@
 import os
 import urllib.request
 import json
+from typing import Optional
 
 import weakref
 from weakref import WeakValueDictionary
@@ -1187,13 +1188,17 @@ def __init__(self,
             uses_eventlet = EventletConnection and issubclass(self.connection_class, EventletConnection)
 
             # Check if we need to download the secure connect bundle
-            if all(akey in cloud for akey in ('db_id', 'db_region', 'token')):
+            if all(akey in cloud for akey in ('db_id', 'token')):
                 # download SCB if necessary
                 if 'secure_connect_bundle' not in cloud:
-                    bundle_path = f'astradb-scb-{cloud["db_id"]}-{cloud["db_region"]}.zip'
+                    bundle_path = f'astradb-scb-{cloud["db_id"]}'
+                    if 'db_region' in cloud:
+                        bundle_path += f'-{cloud["db_region"]}.zip'
+                    else:
+                        bundle_path += '.zip'
                     if not os.path.exists(bundle_path):
                         log.info('Downloading Secure Cloud Bundle...')
-                        url = self._get_astra_bundle_url(cloud['db_id'], cloud["db_region"], cloud['token'])
+                        url = self._get_astra_bundle_url(cloud['db_id'], cloud['token'], cloud["db_region"])
                         try:
                             with urllib.request.urlopen(url) as r:
                                 with open(bundle_path, 'wb') as f:
@@ -2221,15 +2226,15 @@ def get_control_connection_host(self):
         return self.metadata.get_host(endpoint) if endpoint else None
 
     @staticmethod
-    def _get_astra_bundle_url(db_id, db_region, token):
+    def _get_astra_bundle_url(db_id, token, db_region: Optional[str] = None):
         """
         Retrieves the secure connect bundle URL for an Astra DB cluster based on the provided 'db_id',
-        'db_region' and 'token'.
+        'db_region' (optional) and 'token'.
 
         Args:
             db_id (str): The Astra DB cluster UUID.
-            db_region (str): The Astra DB cluster region.
             token (str): The Astra token.
+            db_region (optional str): The Astra DB cluster region.
 
         Returns:
             str: The secure connect bundle URL for the given inputs.
@@ -2248,15 +2253,23 @@ def _get_astra_bundle_url(db_id, db_region, token):
         try:
             with urllib.request.urlopen(req) as response:
                 response_data = json.loads(response.read().decode())
-                for datacenter in response_data:
-                    if 'secureBundleUrl' in datacenter:
-                        # happy path
-                        if datacenter['region'] == db_region:
-                            return datacenter['secureBundleUrl']
+
+                if db_region is not None and len(db_region) > 0:
+                    for datacenter in response_data:
+                        if 'secureBundleUrl' in datacenter and datacenter['secureBundleUrl']:
+                            # happy path
+                            if db_region == datacenter['region']:
+                                return datacenter['secureBundleUrl']
+                            else:
+                                log.warning("Astra DB cluster region [%s] does not match input [%s]", datacenter['region'], db_region)
                         else:
-                            log.warning("Astra DB cluster region [%s] does not match input [%s]", datacenter['region'], db_region)
+                            raise ValueError("'secureBundleUrl' is missing from the Astra DB API response")
+                else:
+                    # Return just the primary region SCB URL
+                    if 'secureBundleUrl' in response_data[0] and response_data[0]['secureBundleUrl']:
+                        return response_data[0]['secureBundleUrl']
                     else:
-                        log.warning("'secureBundleUrl' is missing from the Astra DB API response")
+                        raise ValueError("'secureBundleUrl' is missing from the Astra DB API response for the primary region")
 
                 # handle errors
                 if 'errors' in response_data: