Skip to content

Go 1.11 installation failure: lazygit/pkg/gui fails to typecheck #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spoonscen opened this issue Aug 29, 2018 · 1 comment
Closed

Go 1.11 installation failure: lazygit/pkg/gui fails to typecheck #243

spoonscen opened this issue Aug 29, 2018 · 1 comment

Comments

@spoonscen
Copy link

Describe the bug
Compile errors from # github.com/jesseduffield/lazygit/pkg/gui

To Reproduce
Steps to reproduce the behavior:

  1. Install go version go1.11
  2. Enable Go Mod export GO111MODULE=on
  3. $ go get github.com/jesseduffield/lazygit
  4. See error:
# github.com/jesseduffield/lazygit/pkg/gui
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/branches_panel.go:153:3: g.Update undefined (type *gocui.Gui has no field or method Update)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/commit_message_panel.go:26:3: g.SetViewOnBottom undefined (type *gocui.Gui has no field or method SetViewOnBottom)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/commit_message_panel.go:32:3: g.SetViewOnBottom undefined (type *gocui.Gui has no field or method SetViewOnBottom)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/commit_message_panel.go:40:24: too many arguments in call to g.SetView
	have (string, int, int, int, int, number)
	want (string, int, int, int, int)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/commits_panel.go:12:3: g.Update undefined (type *gocui.Gui has no field or method Update)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:71:40: too many arguments in call to gui.g.SetView
	have (string, int, int, int, int, number)
	want (string, int, int, int, int)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:88:7: gui.g.SetViewOnBottom undefined (type *gocui.Gui has no field or method SetViewOnBottom)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:93:3: g.Update undefined (type *gocui.Gui has no field or method Update)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:123:24: too many arguments in call to g.SetView
	have (string, int, int, int, int, number)
	want (string, int, int, int, int)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:170:25: v.Dimensions undefined (type *gocui.View has no field or method Dimensions)
../../../../pkg/mod/github.com/jesseduffield/[email protected]/pkg/gui/confirmation_panel.go:170:25: too many errors

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac OS
  • Lazygit@latest

Additional context
With the introduction of Go 1.11 Go Vet has been updated, see docs here

The go vet command now reports a fatal error when the package under analysis does not typecheck. Previously, a type checking error simply caused a warning to be printed, and vet to exit with status 1.

@spoonscen
Copy link
Author

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant