Skip to content

Commit 02edd9a

Browse files
committed
Issue GoogleCloudPlatform#262 - src/test/java passed through google-java-format-1.0-all-deps.jar
1 parent 52ffd07 commit 02edd9a

9 files changed

+22
-25
lines changed

jetty9-compat-base/src/test/java/com/google/apphosting/runtime/jetty9/SessionManagerIT.java

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@
1616

1717
package com.google.apphosting.runtime.jetty9;
1818

19-
import static org.easymock.EasyMock.createMock;
20-
import static org.easymock.EasyMock.expect;
21-
import static org.easymock.EasyMock.replay;
22-
import static org.easymock.EasyMock.verify;
23-
import static org.junit.Assert.assertArrayEquals;
24-
2519
import com.google.appengine.api.NamespaceManager;
2620
import com.google.appengine.api.datastore.DatastoreService;
2721
import com.google.appengine.api.datastore.DatastoreServiceFactory;
@@ -52,6 +46,8 @@
5246
import junit.framework.AssertionFailedError;
5347
import junit.framework.TestCase;
5448

49+
import org.easymock.EasyMock;
50+
5551
import java.io.IOException;
5652
import java.io.ObjectInputStream;
5753
import java.io.Serializable;
@@ -66,7 +62,11 @@
6662
import javax.servlet.http.HttpServletRequest;
6763
import javax.servlet.http.HttpSession;
6864

69-
import org.easymock.EasyMock;
65+
import static org.easymock.EasyMock.createMock;
66+
import static org.easymock.EasyMock.expect;
67+
import static org.easymock.EasyMock.replay;
68+
import static org.easymock.EasyMock.verify;
69+
import static org.junit.Assert.assertArrayEquals;
7070

7171
/**
7272
* Tests for SessionManager and its inner classes.
@@ -147,8 +147,7 @@ public String testNamespace() {
147147
return "";
148148
}
149149

150-
public static class NamespacedStartTest extends SessionManagerIT
151-
{
150+
public static class NamespacedStartTest extends SessionManagerIT {
152151
@Override
153152
public String startNamespace() {
154153
return "start-namespace";
@@ -160,8 +159,7 @@ public String testNamespace() {
160159
}
161160
}
162161

163-
public static class NamespacedTest extends SessionManagerIT
164-
{
162+
public static class NamespacedTest extends SessionManagerIT {
165163
@Override
166164
public String startNamespace() {
167165
return "";
@@ -173,8 +171,7 @@ public String testNamespace() {
173171
}
174172
}
175173

176-
public static class NamespacedTestTest extends SessionManagerIT
177-
{
174+
public static class NamespacedTestTest extends SessionManagerIT {
178175
@Override
179176
public String startNamespace() {
180177
return "start-namespace";
@@ -514,7 +511,7 @@ public void testMemcacheOnlyLifecycle() {
514511
* new SessionManager(Collections.<SessionStore>singletonList(new DatastoreSessionStore()));
515512
* HttpServletRequest request = makeMockRequest(true);
516513
* replay(request);
517-
*
514+
* <p>
518515
* AppEngineSession session = manager.newSession(request);
519516
* session.setAttribute("foo", "bar");
520517
* session.save();

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/AppEngineAuthenticationTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151

5252
/**
5353
* Tests for AppEngineAuthentication.
54-
*
55-
* Test plan: Create and configure a ConstraintSecurityHandler to use our AppEngineAuthentication
54+
* <p>
55+
* Test plan: Create and configure a ConstraintSecurityHandler to use our AppEngineAuthentication
5656
* classes, then configure some paths to require users to be logged in. We then fire requests at the
5757
* security handler by calling its handle() method and verify that unauthenticated requests are
5858
* redirected to a login url, while authenticated requests are allowed through.
@@ -125,8 +125,8 @@ public void tearDown() throws Exception {
125125
/**
126126
* Fire one request at the security handler (and by extension to the AuthServlet behind it).
127127
*
128-
* @param path The path to hit.
129-
* @param request The request object to use.
128+
* @param path The path to hit.
129+
* @param request The request object to use.
130130
* @param response The response object to use. Must be created by Mockito.mock()
131131
* @return Any data written to response.getWriter()
132132
*/

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/NoAppWebXmlIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
/**
2222
* Testing that appengine-web.xml can be optional.
23-
*
2423
*/
2524
public class NoAppWebXmlIT extends VmRuntimeTestBase {
2625

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeJettyAuthIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
/**
2828
* Testing Jetty9 auth handling.
29-
*
3029
*/
3130
public class VmRuntimeJettyAuthIT extends VmRuntimeTestBase {
3231

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeJettyKitchenSink2IT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939

4040
/**
4141
* Misc individual Jetty9 vmengines tests.
42-
*
4342
*/
4443
public class VmRuntimeJettyKitchenSink2IT extends VmRuntimeTestBase {
4544

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeJettyKitchenSinkIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434

3535
/**
3636
* Misc individual Jetty9 vmengines tests.
37-
*
3837
*/
3938
public class VmRuntimeJettyKitchenSinkIT extends VmRuntimeTestBase {
4039

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeJettySessionIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ public void testWelcomeServlet() throws Exception {
123123
// code = fetchResponseCode(createUrl("/_ah/health"));
124124
// assertEquals(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, code);
125125
// }
126+
126127
/**
127128
* Create a datastore put response with the minimal fields required to make
128129
* the put succeed.

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeTestBase.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
/**
4141
* Base test class for the Java VmRuntime.
42-
*
42+
* <p>
4343
* Test methods that are Jetty version independent should be implemented in this class.
4444
*/
4545
@Ignore
@@ -106,6 +106,7 @@ protected String[] fetchUrl(URL url) throws IOException {
106106

107107
/**
108108
* Convenience method for fetching from a HttpURLConnection. This allows headers to be set.
109+
*
109110
* @param connection the connection to use
110111
* @return A string array of the lines in the response.
111112
*/
@@ -161,7 +162,10 @@ protected HttpURLConnection openConnection(String path) throws IOException {
161162
conn.setRequestProperty("Metadata-Flavor", "Google");
162163
return conn;
163164
}
164-
/** Timeout in milliseconds to retrieve data from the server. */
165+
166+
/**
167+
* Timeout in milliseconds to retrieve data from the server.
168+
*/
165169
private static final int TIMEOUT_MILLIS = 120 * 1000;
166170

167171
protected String getMetadataFromServer(String path) throws IOException {

jetty9-compat-base/src/test/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeWebAppContextTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
/**
4444
* Test VmRuntimeWebAppContext directly, without using VmRuntimeTestBase
45-
*
4645
*/
4746
public class VmRuntimeWebAppContextTest {
4847

0 commit comments

Comments
 (0)