Skip to content

Commit a4abef9

Browse files
authored
improvement way to get root SDK versions
just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables additionally, changed the SDK values from 23 to 26 as per new changes from react-native and Android Android Target API Level 26 will be required in August 2018. https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html And the React Native team is already working on this: facebook/react-native#18095 facebook/react-native#17741 PS: I am aware of this PR #128 but first its still targeting old SDK values i.e 23 as fallback and secondly I am not sure of the use of `project` to get the value instead of proper way i.e `rootProject.ext` to get the property value.
1 parent 073cc3c commit a4abef9

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

android/build.gradle

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
apply plugin: 'com.android.library'
22

3+
def safeExtGet(prop, fallback) {
4+
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
5+
}
6+
37
repositories {
48
mavenCentral()
59
}
@@ -14,11 +18,11 @@ buildscript {
1418
}
1519

1620
android {
17-
compileSdkVersion 23
18-
buildToolsVersion "23.0.1"
21+
compileSdkVersion safeExtGet('compileSdkVersion', 26)
22+
buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3')
1923
defaultConfig {
20-
minSdkVersion 16
21-
targetSdkVersion 23
24+
minSdkVersion safeExtGet('minSdkVersion', 16)
25+
targetSdkVersion safeExtGet('targetSdkVersion', 26)
2226
versionCode 1
2327
versionName "1.0"
2428
}
@@ -33,7 +37,7 @@ android {
3337
}
3438

3539
dependencies {
36-
compile 'com.facebook.react:react-native:+'
40+
compile 'com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}'
3741
//compile 'com.squareup.okhttp3:okhttp:+'
3842
//{RNFetchBlob_PRE_0.28_DEPDENDENCY}
3943
}

0 commit comments

Comments
 (0)