Skip to content

Commit 5b56d13

Browse files
authored
Merge pull request #23 from philall/master
fix import error
2 parents 0612b65 + 355e139 commit 5b56d13

File tree

4 files changed

+18
-11
lines changed

4 files changed

+18
-11
lines changed

requirements-test.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Django>=1.6
22
djangorestframework>=2.4.3
3-
pytest-django==2.6
4-
pytest==2.5.2
5-
pytest-cov==1.6
6-
flake8==2.2.2
3+
pytest-django==3.1.2
4+
pytest==3.1.3
5+
pytest-cov==2.5.1
6+
flake8==3.3.0

rest_framework_xml/renderers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from django.utils import six
77
from django.utils.xmlutils import SimplerXMLGenerator
88
from django.utils.six.moves import StringIO
9-
from django.utils.encoding import smart_text
9+
from django.utils.encoding import force_text
1010
from rest_framework.renderers import BaseRenderer
1111

1212

@@ -58,4 +58,4 @@ def _to_xml(self, xml, data):
5858
pass
5959

6060
else:
61-
xml.characters(smart_text(data))
61+
xml.characters(force_text(data))

tests/test_parsers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
from django.test import TestCase
7-
from django.utils import unittest
7+
from django.test.utils import skipUnless
88
from django.utils.six.moves import StringIO
99
from rest_framework_xml.parsers import XMLParser
1010
from rest_framework_xml.compat import etree
@@ -53,13 +53,13 @@ def setUp(self):
5353
]
5454
}
5555

56-
@unittest.skipUnless(etree, 'defusedxml not installed')
56+
@skipUnless(etree, 'defusedxml not installed')
5757
def test_parse(self):
5858
parser = XMLParser()
5959
data = parser.parse(self._input)
6060
self.assertEqual(data, self._data)
6161

62-
@unittest.skipUnless(etree, 'defusedxml not installed')
62+
@skipUnless(etree, 'defusedxml not installed')
6363
def test_complex_data_parse(self):
6464
parser = XMLParser()
6565
data = parser.parse(self._complex_data_input)

tests/test_renderers.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
from decimal import Decimal
66

77
from django.test import TestCase
8-
from django.utils import unittest
8+
from django.test.utils import skipUnless
99
from django.utils.six.moves import StringIO
10+
from django.utils.translation import gettext_lazy
1011
from rest_framework_xml.renderers import XMLRenderer
1112
from rest_framework_xml.parsers import XMLParser
1213
from rest_framework_xml.compat import etree
@@ -97,7 +98,13 @@ def test_render_list(self):
9798
self.assertXMLContains(content, '<sub_data_list><list-item>')
9899
self.assertXMLContains(content, '</list-item></sub_data_list>')
99100

100-
@unittest.skipUnless(etree, 'defusedxml not installed')
101+
def test_render_lazy(self):
102+
renderer = XMLRenderer()
103+
lazy = gettext_lazy('hello')
104+
content = renderer.render({'field': lazy}, 'application/xml')
105+
self.assertXMLContains(content, '<field>hello</field>')
106+
107+
@skipUnless(etree, 'defusedxml not installed')
101108
def test_render_and_parse_complex_data(self):
102109
"""
103110
Test XML rendering.

0 commit comments

Comments
 (0)