Skip to content

this.setState() won't trigger a re-render of HtmlView #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pedrodevoto opened this issue Mar 22, 2016 · 4 comments
Closed

this.setState() won't trigger a re-render of HtmlView #11

pedrodevoto opened this issue Mar 22, 2016 · 4 comments

Comments

@pedrodevoto
Copy link

If I set the value prop to some state variable and then set that variable through setState() function, the HtmlView does not get refreshed with the new value. Haven't had much time to check the source for myself.

@pedrodevoto
Copy link
Author

Fixed it by commenting out line number 76 on HTMLView.js.

...
componentWillReceiveProps() {
  // if (this.state.element) return
  this.startHtmlRender()
},
...

I don't know yet if I broke something else by doing so.

@sf577
Copy link

sf577 commented Apr 7, 2016

Ive issued a Pull Request so this now works, hopefully this will be merged in

@pedrodevoto
Copy link
Author

Working fine with new merge

@WhatAKitty
Copy link

@sf577 @pedrodevoto I have this problem and not working fine in new version: 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants