Skip to content

Commit 2f3bae9

Browse files
committed
factor out then-fs and promise.finally
1 parent 8055eec commit 2f3bae9

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

lib/jsdoc-command.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
'use strict'
22
const arrayify = require('array-back')
33
const path = require('path')
4-
const promiseFinally = require('promise.prototype.finally')
5-
promiseFinally.shim()
64

75
/**
86
* @module jsdoc-command
@@ -53,12 +51,13 @@ class JsdocCommand {
5351
if (this.output instanceof Promise) {
5452
return this.output
5553
.then(result => {
54+
this.postExecute()
5655
return result
5756
})
5857
.catch(err => {
58+
this.postExecute()
5959
throw err
6060
})
61-
.finally(() => this.postExecute())
6261
} else {
6362
this.postExecute()
6463
return this.output
@@ -126,7 +125,7 @@ class JsdocCommand {
126125
*/
127126
readCache () {
128127
if (this.cache) {
129-
const fs = require('then-fs')
128+
const fs = require('fs-then-native')
130129
const promises = this.inputFileSet.files.map(file => fs.readFile(file, 'utf8'))
131130
return Promise.all(promises)
132131
.then(contents => {

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
"cover": "istanbul cover ./node_modules/.bin/test-runner test/*.js && cat coverage/lcov.info | ./node_modules/.bin/coveralls && rm -rf coverage; echo"
2525
},
2626
"devDependencies": {
27-
"babel-preset-es2015": "^6.14.0",
27+
"babel-preset-es2015": "^6.16.0",
2828
"collect-json": "^1.0.8",
29-
"core-assert": "~0.2.0",
29+
"core-assert": "~0.2.1",
3030
"coveralls": "^2.11.14",
3131
"jsdoc-to-markdown": "^2.0.0-alpha.8",
3232
"rimraf": "^2.5.4",
@@ -38,12 +38,11 @@
3838
"collect-all": "^1.0.2",
3939
"core-js": "^2.4.1",
4040
"feature-detect-es6": "^1.3.1",
41-
"file-set": "^1.0.2",
41+
"file-set": "^1.1.1",
42+
"fs-then-native": "^0.1.0",
4243
"jsdoc-75lb": "^3.5.6",
4344
"object-to-spawn-args": "^1.1.0",
44-
"promise.prototype.finally": "^2.0.1",
4545
"temp-path": "^1.0.0",
46-
"then-fs": "^2.0.0",
4746
"walk-back": "^2.0.1"
4847
},
4948
"standard": {

0 commit comments

Comments
 (0)