Skip to content

Commit d3ebfaf

Browse files
maureimaurei
committed
Feedback
1 parent 4073c3f commit d3ebfaf

File tree

3 files changed

+98
-99
lines changed

3 files changed

+98
-99
lines changed

‎test/OpenApiClientTests/LegacyClient/ClientAttributeRegistrationLifeTimeTests.cs

+33-33
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public async Task Disposed_attribute_registration_for_document_does_not_affect_r
1414
{
1515
// Arrange
1616
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
17-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
17+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
1818

1919
const string airplaneId = "XUuiP";
2020

@@ -28,16 +28,16 @@ public async Task Disposed_attribute_registration_for_document_does_not_affect_r
2828
}
2929
};
3030

31-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
31+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
3232
airplane => airplane.AirtimeInHours))
3333
{
34-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument));
34+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument));
3535
}
3636

3737
wrapper.ChangeResponse(HttpStatusCode.NoContent, null);
3838

3939
// Act
40-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument));
40+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument));
4141

4242
// Assert
4343
wrapper.RequestBody.Should().BeJson(@"{
@@ -56,7 +56,7 @@ public async Task Attribute_registration_can_be_used_for_multiple_requests()
5656
{
5757
// Arrange
5858
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
59-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
59+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
6060

6161
const string airplaneId = "XUuiP";
6262

@@ -73,17 +73,17 @@ public async Task Attribute_registration_can_be_used_for_multiple_requests()
7373
}
7474
};
7575

76-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
76+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
7777
airplane => airplane.AirtimeInHours))
7878
{
79-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument));
79+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument));
8080

8181
wrapper.ChangeResponse(HttpStatusCode.NoContent, null);
8282

8383
requestDocument.Data.Attributes.AirtimeInHours = null;
8484

8585
// Act
86-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument));
86+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument));
8787
}
8888

8989
// Assert
@@ -103,7 +103,7 @@ public async Task Request_is_unaffected_by_attribute_registration_for_different_
103103
{
104104
// Arrange
105105
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
106-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
106+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
107107

108108
const string airplaneId1 = "XUuiP";
109109

@@ -129,16 +129,16 @@ public async Task Request_is_unaffected_by_attribute_registration_for_different_
129129
}
130130
};
131131

132-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
132+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
133133
airplane => airplane.AirtimeInHours))
134134
{
135-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
135+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
136136
airplane => airplane.SerialNumber))
137137
{
138138
}
139139

140140
// Act
141-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
141+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
142142
}
143143

144144
// Assert
@@ -158,7 +158,7 @@ public async Task Attribute_values_can_be_changed_after_attribute_registration()
158158
{
159159
// Arrange
160160
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
161-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
161+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
162162

163163
const string airplaneId = "XUuiP";
164164

@@ -175,13 +175,13 @@ public async Task Attribute_values_can_be_changed_after_attribute_registration()
175175
}
176176
};
177177

178-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
178+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument,
179179
airplane => airplane.IsInMaintenance))
180180
{
181181
requestDocument.Data.Attributes.IsInMaintenance = false;
182182

183183
// Act
184-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument));
184+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument));
185185
}
186186

187187
// Assert
@@ -201,7 +201,7 @@ public async Task Attribute_registration_is_unaffected_by_successive_attribute_r
201201
{
202202
// Arrange
203203
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
204-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
204+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
205205

206206
const string airplaneId1 = "XUuiP";
207207

@@ -224,14 +224,14 @@ public async Task Attribute_registration_is_unaffected_by_successive_attribute_r
224224
}
225225
};
226226

227-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
227+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
228228
airplane => airplane.IsInMaintenance))
229229
{
230-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePostRequestDocument, AirplaneAttributesInPostRequest>(requestDocument2,
230+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePostRequestDocument, AirplaneAttributesInPostRequest>(requestDocument2,
231231
airplane => airplane.AirtimeInHours))
232232
{
233233
// Act
234-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId1, requestDocument1));
234+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId1, requestDocument1));
235235
}
236236
}
237237

@@ -252,7 +252,7 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
252252
{
253253
// Arrange
254254
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
255-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
255+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
256256

257257
const string airplaneId1 = "XUuiP";
258258

@@ -266,10 +266,10 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
266266
}
267267
};
268268

269-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
269+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
270270
airplane => airplane.AirtimeInHours))
271271
{
272-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId1, requestDocument1));
272+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId1, requestDocument1));
273273
}
274274

275275
const string airplaneId2 = "DJy1u";
@@ -289,11 +289,11 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
289289

290290
wrapper.ChangeResponse(HttpStatusCode.NoContent, null);
291291

292-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
292+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
293293
airplane => airplane.SerialNumber))
294294
{
295295
// Act
296-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
296+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
297297
}
298298

299299
// Assert
@@ -314,7 +314,7 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
314314
{
315315
// Arrange
316316
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
317-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
317+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
318318

319319
var requestDocument1 = new AirplanePostRequestDocument
320320
{
@@ -325,10 +325,10 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
325325
}
326326
};
327327

328-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePostRequestDocument, AirplaneAttributesInPostRequest>(requestDocument1,
328+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePostRequestDocument, AirplaneAttributesInPostRequest>(requestDocument1,
329329
airplane => airplane.AirtimeInHours))
330330
{
331-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PostAirplaneAsync(requestDocument1));
331+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PostAirplaneAsync(requestDocument1));
332332
}
333333

334334
const string airplaneId = "DJy1u";
@@ -348,11 +348,11 @@ public async Task Attribute_registration_is_unaffected_by_preceding_disposed_att
348348

349349
wrapper.ChangeResponse(HttpStatusCode.NoContent, null);
350350

351-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
351+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
352352
airplane => airplane.SerialNumber))
353353
{
354354
// Act
355-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId, requestDocument2));
355+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId, requestDocument2));
356356
}
357357

358358
// Assert
@@ -373,7 +373,7 @@ public async Task Attribute_registration_is_unaffected_by_preceding_attribute_re
373373
{
374374
// Arrange
375375
using var wrapper = FakeHttpClientWrapper.Create(HttpStatusCode.NoContent, null);
376-
IOpenApiClient openApiClient = new OpenApiClient(wrapper.HttpClient);
376+
IOpenApiClient apiClient = new OpenApiClient(wrapper.HttpClient);
377377

378378
const string airplaneId1 = "XUuiP";
379379

@@ -399,14 +399,14 @@ public async Task Attribute_registration_is_unaffected_by_preceding_attribute_re
399399
}
400400
};
401401

402-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
402+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument1,
403403
airplane => airplane.SerialNumber))
404404
{
405-
using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
405+
using (apiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
406406
airplane => airplane.IsInMaintenance, airplane => airplane.AirtimeInHours))
407407
{
408408
// Act
409-
_ = await ApiResponse.TranslateAsync(async () => await openApiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
409+
_ = await ApiResponse.TranslateAsync(async () => await apiClient.PatchAirplaneAsync(airplaneId2, requestDocument2));
410410
}
411411
}
412412

0 commit comments

Comments
 (0)