Skip to content

Marshal benchmark is outdated #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
funny-falcon opened this issue Jan 12, 2019 · 1 comment
Open

Marshal benchmark is outdated #339

funny-falcon opened this issue Jan 12, 2019 · 1 comment

Comments

@funny-falcon
Copy link

Commit 7581017 unavoidably increases allocations for buffer. But benchmark results in README were not updated to reflect that changes.

Why those commit were done at all? Why allocation care core were replaced with allocation unaware?

I see that simplifies code a lot. But couple of tweaks could make new simple code also allocation aware without introducing much complexity.

@funny-falcon
Copy link
Author

Though, if stream is used without passing io.Writer to, then new code certainly works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant