Skip to content

Make existing "dependencies" test optional in 2019-09 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
handrews opened this issue Nov 11, 2019 · 3 comments
Closed

Make existing "dependencies" test optional in 2019-09 #303

handrews opened this issue Nov 11, 2019 · 3 comments
Milestone

Comments

@handrews
Copy link
Contributor

Since we reserve this keyword for compatibility (including in the default meta-schema), let's keep it around but move it to the optional section.

@handrews handrews added this to the 2019-09 milestone Nov 11, 2019
@Julian Julian added missing test A request to add a test to the suite that is currently not covered elsewhere. and removed missing test A request to add a test to the suite that is currently not covered elsewhere. labels Nov 29, 2019
@Julian
Copy link
Member

Julian commented Nov 29, 2019

Hm -- is this really optional though?

Isn't the rename strictly for "preventing" downstream folks from redefining their own dependencies thing in their own vocabulary?

And so, isn't being able to reference arbitrary locations in a schema not in fact optional -- the fact that the place is called "dependencies" and happens to be the same place as a previous draft recommended is just a "coincidence"?

If the above understanding is correct it'd seem to me like if we do want to keep testing this that it should stay where it is, no?

@Julian
Copy link
Member

Julian commented Dec 21, 2019

Sorry, I somehow read this to be about definitions -- so never mind that last comment, but now I need to see what it means that we've kept this optional -- basically using it still applies the old behavior, but it's deprecated/discouraged essentially, or is it really optional that an implementation implements it? That'd sound a bit unfortunate to me if so, but need to read the spec I suppose.

@karenetheridge
Copy link
Member

Those tests were removed in commit 960f519.

@Julian Julian closed this as completed in 07c45c0 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants