Skip to content

Commit 51dd997

Browse files
authored
Merge pull request #458 from benjagm/main
Code cleanup in the github actions for better fetch and authentication
2 parents 0194932 + b062052 commit 51dd997

File tree

3 files changed

+17
-62
lines changed

3 files changed

+17
-62
lines changed

.github/workflows/close-completed-ocwm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
const octokit = require('@octokit/core').Octokit
3636
const mygithub = new octokit({
3737
request: { fetch: fetch,},
38-
headers: { authorization: `token ${process.env.MY_TOKEN}`}
38+
auth: process.env.MY_TOKEN
3939
});
4040
4141
const label = process.env.MY_LABEL;

.github/workflows/ocwm-creator.yml

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Set up Node 18
1717
uses: actions/setup-node@v2
1818
with:
19-
node-version: 18
19+
node-version: '18'
2020
- name: Set up Python
2121
uses: actions/setup-python@v2
2222
with:
@@ -37,44 +37,22 @@ jobs:
3737
token: ${{ secrets.AUTH_TOKEN }}
3838

3939
- name: Install dependencies
40-
run: npm install @octokit/core axios
40+
run: npm install @octokit/core
4141

4242
- name: Update Issue Body
4343
uses: actions/github-script@v6
4444
env:
4545
MY_TOKEN: ${{ secrets.AUTH_TOKEN }}
4646
with:
4747
script: |
48-
const { Octokit } = require('@octokit/core');
49-
const axios = require('axios').default;
50-
51-
const customFetch = async (url, options) => {
52-
const res = await axios({
53-
url,
54-
method: options.method || 'GET',
55-
headers: {
56-
...options.headers,
57-
authorization: `token ${process.env.MY_TOKEN}`,
58-
},
59-
data: options.body,
60-
});
61-
62-
return {
63-
ok: res.status >= 200 && res.status <= 299,
64-
status: res.status,
65-
statusText: res.statusText,
66-
json: () => res.data,
67-
text: () => res.data,
68-
headers: res.headers,
69-
};
70-
};
71-
72-
const mygithub = new Octokit({
73-
request: {
74-
fetch: customFetch,
75-
},
48+
49+
const octokit = require('@octokit/core').Octokit;
50+
const mygithub = new octokit({
51+
request: { fetch: fetch,},
52+
auth: process.env.MY_TOKEN
7653
});
7754
55+
console.log("Token:" + process.env.MY_TOKEN);
7856
const ocwmnumber = ${{ steps.create-issue.outputs.issue-number }};
7957
8058
const { data: ocwmissue } = await mygithub.request(`GET /repos/${context.repo.owner}/${context.repo.repo}/issues/${ ocwmnumber }`, {

.github/workflows/ocwm-issue-collector.yml

Lines changed: 8 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ jobs:
1313
steps:
1414
- uses: actions/checkout@v2
1515
- name: Set up Node 18
16-
uses: actions/setup-node@v3
16+
uses: actions/setup-node@v2
1717
with:
18-
node-version: 18
18+
node-version: '18'
1919
- name: Install dependencies
20-
run: npm install @octokit/core axios
20+
run: npm install @octokit/core
2121
- name: Adding Issues
2222
uses: actions/github-script@v6
2323
env:
@@ -30,35 +30,12 @@ jobs:
3030
MY_TOKEN: ${{ secrets.AUTH_TOKEN }}
3131
with:
3232
script: |
33-
const { Octokit } = require('@octokit/core');
34-
const axios = require('axios').default;
35-
36-
const customFetch = async (url, options) => {
37-
const res = await axios({
38-
url,
39-
method: options.method || 'GET',
40-
headers: {
41-
...options.headers,
42-
authorization: `token ${process.env.MY_TOKEN}`,
43-
},
44-
data: options.body,
45-
});
4633
47-
return {
48-
ok: res.status >= 200 && res.status <= 299,
49-
status: res.status,
50-
statusText: res.statusText,
51-
json: () => res.data,
52-
text: () => res.data,
53-
headers: res.headers,
54-
};
55-
};
56-
57-
const mygithub = new Octokit({
58-
request: {
59-
fetch: customFetch,
60-
},
61-
});
34+
const octokit = require('@octokit/core').Octokit
35+
const mygithub = new octokit({
36+
request: { fetch: fetch,},
37+
auth: process.env.MY_TOKEN
38+
});
6239
6340
const repoNames = process.env.REPO_NAMES;
6441
const placeholder = process.env.PLACEHOLDER;

0 commit comments

Comments
 (0)