Skip to content

🐛 Bug: Logo color is incorrect on initial load in dark mode #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdityaBhate opened this issue Jun 12, 2024 · 4 comments
Closed

🐛 Bug: Logo color is incorrect on initial load in dark mode #756

AdityaBhate opened this issue Jun 12, 2024 · 4 comments
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Stale It's believed that this issue is no longer important to the requestor. Status: Triage This is the initial status for an issue that requires triage.

Comments

@AdityaBhate
Copy link

Describe the bug

When visiting the website for the first time, the default theme is dark mode, but the logo color is black instead of white. This issue is resolved when toggling the theme switcher (light/dark mode).

Steps To Reproduce

  1. Visit the website for the first time (ensure no previous theme settings are stored).
  2. Observe the logo color in dark mode.
  3. Toggle the theme switcher to light mode and back to dark mode.
  4. Observe the logo color changes to white correctly.

Expected Behavior

The logo should be white on the initial load when dark mode is the default theme.

Screenshots

Initial Load (chrome, incognito)
image


After Toggling the to Light Mode and then to Dark Mode
ezgif-5-6862d1b9d8

Device Information [optional]

- OS: Windows 11
- Browser: Chrome
- version: 125.0.6422.142 (Official Build) (64-bit)

- Browser: Firefox
- version: Version 126.0.1 (64-bit)

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes

@AdityaBhate AdityaBhate added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jun 12, 2024
Copy link

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look to our contributors guide if you plan on opening a pull request.
For more details check out README.md file.

@AdityaBhate
Copy link
Author

Assign me this issue, I would like to work on this

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Jun 17, 2024

Hi @AdityaBhate. This issues has been resolved in pull request #735

Copy link

Hello! 👋

This issue has been automatically marked as stale due to inactivity 😴

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience ❤️

@github-actions github-actions bot added the Status: Stale It's believed that this issue is no longer important to the requestor. label Jul 21, 2024
@benjagm benjagm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Stale It's believed that this issue is no longer important to the requestor. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

No branches or pull requests

3 participants