Skip to content

Commit fd6fff8

Browse files
committed
fix: doesn't trigger on strings containing a quote character
1 parent 1b4037f commit fd6fff8

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/rules/jsx-curly-brace-presence.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ module.exports = {
268268
&& !containsMultilineComment(expression.value)
269269
&& !needToEscapeCharacterForJSX(expression.raw, JSXExpressionNode) && (
270270
jsxUtil.isJSX(JSXExpressionNode.parent)
271-
|| !containsQuoteCharacters(expression.value)
271+
|| (!containsQuoteCharacters(expression.value) || typeof expression.value === 'string')
272272
)
273273
) {
274274
reportUnnecessaryCurly(JSXExpressionNode);

tests/lib/rules/jsx-curly-brace-presence.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,13 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
934934
errors: [{ messageId: 'unnecessaryCurly' }],
935935
options: [{ props: 'never', children: 'never', propElementValues: 'never' }],
936936
features: ['no-ts'],
937+
},
938+
{
939+
code: `<Foo bar={"'"} />`,
940+
output: `<Foo bar="'" />`,
941+
errors: [{ messageId: 'unnecessaryCurly' }],
942+
options: [{ props: 'never', children: 'never', propElementValues: 'never' }],
943+
features: ['no-ts'],
937944
}
938945
)),
939946
});

0 commit comments

Comments
 (0)