Skip to content

Further improvements #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Further improvements #3

merged 1 commit into from
Sep 19, 2017

Conversation

saschatimme
Copy link
Collaborator

There was an unnecessary additional for loop. After I removed it the performance improved even further. I think the code is now nearly optimal.

x + y + 1
BenchmarkTools.Trial: 
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     23.995 ns (0.00% GC)
  median time:      24.200 ns (0.00% GC)
  mean time:        26.700 ns (0.00% GC)
  maximum time:     614.453 ns (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     996

x^4 + 4x^3 + 6x^2 + 4x + y + 1
BenchmarkTools.Trial: 
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     34.365 ns (0.00% GC)
  median time:      36.947 ns (0.00% GC)
  mean time:        55.722 ns (0.00% GC)
  maximum time:     24.551 μs (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     992

50x^3 + 83x^2y + 24xy^2 + y^3 + 392x^2 + 414xy + 50y^2 - 28x + 59y - 100
BenchmarkTools.Trial: 
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     45.447 ns (0.00% GC)
  median time:      45.685 ns (0.00% GC)
  mean time:        50.081 ns (0.00% GC)
  maximum time:     238.315 ns (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     989

x^4y^2 + 10x^3y^2 + 3x^3y + 15x^2y^2 + xy^3 + 10x^2y + 10xy^2 + x^2 + 10xy + x + y
BenchmarkTools.Trial: 
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     49.255 ns (0.00% GC)
  median time:      49.745 ns (0.00% GC)
  mean time:        54.466 ns (0.00% GC)
  maximum time:     659.012 ns (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     987

@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files           3        3           
  Lines         240      240           
=======================================
  Hits          227      227           
  Misses         13       13
Impacted Files Coverage Δ
src/poly.jl 96.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5e8c0...5c4c7f2. Read the comment docs.

@saschatimme saschatimme merged commit 6eee7ce into master Sep 19, 2017
@saschatimme saschatimme deleted the faster_evaluation branch September 19, 2017 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant