Skip to content

Commit 8b5231e

Browse files
DanielRufKent C. Dodds
authored and
Kent C. Dodds
committed
chore(ci): test Node.js 8, 10 and 11 (testing-library#148)
<!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: All supported Node.js versions should be tested to catch any issues on newer LTS releases. **Why**: To ensure that there are no breaking builds on Node.js 6, 10 and 11. **How**: Updated the Travis CI config. **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation - [ ] Tests - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
1 parent b07bf6b commit 8b5231e

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.travis.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ cache:
55
- ~/.npm
66
notifications:
77
email: false
8-
node_js: '8'
8+
node_js:
9+
- 'node'
10+
- '10'
11+
- '8'
912
install: npm install
1013
script: npm run validate
1114
after_success: kcd-scripts travis-after-success

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)",
2222
"license": "MIT",
2323
"engines": {
24-
"node": ">=6"
24+
"node": ">=8"
2525
},
2626
"scripts": {
2727
"add-contributor": "kcd-scripts contributors add",

0 commit comments

Comments
 (0)