@@ -62,30 +62,30 @@ class DiscoveryTests extends AbstractJupiterTestEngineTests {
62
62
@ Test
63
63
void discoverTestClass () {
64
64
LauncherDiscoveryRequest request = defaultRequest ().selectors (selectClass (LocalTestCase .class )).build ();
65
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
65
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
66
66
assertEquals (7 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
67
67
}
68
68
69
69
@ Test
70
70
void doNotDiscoverAbstractTestClass () {
71
71
LauncherDiscoveryRequest request = defaultRequest ().selectors (selectClass (AbstractTestCase .class )).build ();
72
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
72
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
73
73
assertEquals (0 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
74
74
}
75
75
76
76
@ Test
77
77
void discoverMethodByUniqueId () {
78
78
LauncherDiscoveryRequest request = defaultRequest ().selectors (
79
79
selectUniqueId (JupiterUniqueIdBuilder .uniqueIdForMethod (LocalTestCase .class , "test1()" ))).build ();
80
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
80
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
81
81
assertEquals (2 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
82
82
}
83
83
84
84
@ Test
85
85
void discoverMethodByUniqueIdForOverloadedMethod () {
86
86
LauncherDiscoveryRequest request = defaultRequest ().selectors (
87
87
selectUniqueId (JupiterUniqueIdBuilder .uniqueIdForMethod (LocalTestCase .class , "test4()" ))).build ();
88
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
88
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
89
89
assertEquals (2 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
90
90
}
91
91
@@ -94,7 +94,7 @@ void discoverMethodByUniqueIdForOverloadedMethodVariantThatAcceptsArguments() {
94
94
LauncherDiscoveryRequest request = defaultRequest ().selectors (
95
95
selectUniqueId (JupiterUniqueIdBuilder .uniqueIdForMethod (LocalTestCase .class ,
96
96
"test4(" + TestInfo .class .getName () + ")" ))).build ();
97
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
97
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
98
98
assertEquals (2 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
99
99
}
100
100
@@ -104,7 +104,7 @@ void discoverMethodByMethodReference() throws NoSuchMethodException {
104
104
105
105
LauncherDiscoveryRequest request = defaultRequest ().selectors (
106
106
selectMethod (LocalTestCase .class , testMethod )).build ();
107
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
107
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
108
108
assertEquals (2 , engineDescriptor .getDescendants ().size (), "# resolved test descriptors" );
109
109
}
110
110
@@ -113,7 +113,7 @@ void discoverMultipleMethodsOfSameClass() {
113
113
LauncherDiscoveryRequest request = defaultRequest ().selectors (selectMethod (LocalTestCase .class , "test1" ),
114
114
selectMethod (LocalTestCase .class , "test2" )).build ();
115
115
116
- TestDescriptor engineDescriptor = discoverTests (request ). getEngineDescriptor ( );
116
+ TestDescriptor engineDescriptor = discoverTestsWithoutIssues (request );
117
117
118
118
assertThat (engineDescriptor .getChildren ()).hasSize (1 );
119
119
TestDescriptor classDescriptor = getOnlyElement (engineDescriptor .getChildren ());
@@ -332,14 +332,23 @@ void reportsWarningsForBlankDisplayNames() throws NoSuchMethodException {
332
332
.contains (org .junit .platform .engine .support .descriptor .MethodSource .from (method ));
333
333
}
334
334
335
+ private TestDescriptor discoverTestsWithoutIssues (LauncherDiscoveryRequest request ) {
336
+ var results = super .discoverTests (request );
337
+ assertThat (results .getDiscoveryIssues ()).isEmpty ();
338
+ return results .getEngineDescriptor ();
339
+ }
340
+
335
341
// -------------------------------------------------------------------
336
342
337
343
@ SuppressWarnings ("unused" )
338
- private static abstract class AbstractTestCase {
344
+ static abstract class AbstractTestCase {
339
345
340
346
@ Test
341
- void abstractTest () {
347
+ void test () {
342
348
}
349
+
350
+ @ Test
351
+ abstract void abstractTest ();
343
352
}
344
353
345
354
@ SuppressWarnings ("JUnitMalformedDeclaration" )
0 commit comments