Remove direct use of distutils #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

blink1073 opened this issue Sep 11, 2020 · 4 comments · Fixed by #123

Contributor

blink1073 commented Sep 11, 2020 •

edited

Loading

jupyter-packaging/jupyter_packaging/setupbase.py

Line 32 in 9d884df

from distutils import log

cf https://www.python.org/dev/peps/pep-0632/ and https://setuptools.readthedocs.io/en/latest/deprecated/distutils-legacy.html

Contributor Author

blink1073 commented Sep 11, 2020

We can instead import from https://github.com/pypa/setuptools/blob/f991fbb3c9d0e10a0a78ae2b508b3fd99f9cdef2/setuptools/command/sdist.py#L1 on

jupyter-packaging/jupyter_packaging/setupbase.py

Line 31 in 9d884df

from setuptools.command.sdist import sdist

Contributor Author

blink1073 commented Sep 11, 2020

It looks like we should keep using distutils.log for now:

https://github.com/pypa/setuptools/blob/ba209a15247b9578d565b7491f88dc1142ba29e4/docs/distutils-legacy.txt

Contributor Author

blink1073 commented Feb 12, 2021

cf #66

Contributor Author

blink1073 commented Dec 29, 2021

We can now use standard logging if we use setuptools 60.2

blink1073 mentioned this issue

Stop using distutils.log #123

Merged

blink1073 closed this as completed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment