Skip to content

Commit 7e8fb1a

Browse files
authored
Merge pull request #6026 from faucct/patch-1
Correct 'Content-Type' headers
2 parents b97dda1 + 5ab8717 commit 7e8fb1a

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

notebook/gateway/managers.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,13 @@ def load_connection_args(self, **kwargs):
299299
if len(self._static_args) == 0:
300300
self.init_static_args()
301301

302-
kwargs.update(self._static_args)
302+
for arg, static_value in self._static_args.items():
303+
if arg == 'headers':
304+
given_value = kwargs.setdefault(arg, {})
305+
if isinstance(given_value, dict):
306+
given_value.update(static_value)
307+
else:
308+
kwargs[arg] = static_value
303309
return kwargs
304310

305311

@@ -401,7 +407,9 @@ async def start_kernel(self, kernel_id=None, path=None, **kwargs):
401407

402408
json_body = json_encode({'name': kernel_name, 'env': kernel_env})
403409

404-
response = await gateway_request(kernel_url, method='POST', body=json_body)
410+
response = await gateway_request(
411+
kernel_url, method='POST', headers={'Content-Type': 'application/json'}, body=json_body
412+
)
405413
kernel = json_decode(response.body)
406414
kernel_id = kernel['id']
407415
self.log.info("Kernel started: %s" % kernel_id)
@@ -489,7 +497,9 @@ async def restart_kernel(self, kernel_id, now=False, **kwargs):
489497
"""
490498
kernel_url = self._get_kernel_endpoint_url(kernel_id) + '/restart'
491499
self.log.debug("Request restart kernel at: %s", kernel_url)
492-
response = await gateway_request(kernel_url, method='POST', body=json_encode({}))
500+
response = await gateway_request(
501+
kernel_url, method='POST', headers={'Content-Type': 'application/json'}, body=json_encode({})
502+
)
493503
self.log.debug("Restart kernel response: %d %s", response.code, response.reason)
494504

495505
async def interrupt_kernel(self, kernel_id, **kwargs):
@@ -502,7 +512,9 @@ async def interrupt_kernel(self, kernel_id, **kwargs):
502512
"""
503513
kernel_url = self._get_kernel_endpoint_url(kernel_id) + '/interrupt'
504514
self.log.debug("Request interrupt kernel at: %s", kernel_url)
505-
response = await gateway_request(kernel_url, method='POST', body=json_encode({}))
515+
response = await gateway_request(
516+
kernel_url, method='POST', headers={'Content-Type': 'application/json'}, body=json_encode({})
517+
)
506518
self.log.debug("Interrupt kernel response: %d %s", response.code, response.reason)
507519

508520
def shutdown_all(self, now=False):

0 commit comments

Comments
 (0)