magento#34505: fix failed static tests

Author: karyna-t

app/code/Magento/Bundle/Pricing/Price/BundleSelectionPrice.php

@@ -26,16 +26,14 @@ class BundleSelectionPrice extends AbstractPrice
     /**
      * Price model code
      */
-    const PRICE_CODE = 'bundle_selection';
+    public const PRICE_CODE = 'bundle_selection';
 
     /**
      * @var \Magento\Catalog\Model\Product
      */
     protected $bundleProduct;
 
     /**
-     * Event manager
-     *
      * @var \Magento\Framework\Event\ManagerInterface
      */
     protected $eventManager;
@@ -181,6 +179,8 @@ public function getAmount()
     }
 
     /**
+     * Returns the bundle product.
+     *
      * @return SaleableInterface
      */
     public function getProduct()

app/code/Magento/Cms/Model/Block.php

@@ -29,17 +29,17 @@ class Block extends AbstractModel implements BlockInterface, IdentityInterface
     /**
      * CMS block cache tag
      */
-    const CACHE_TAG = 'cms_b';
+    public const CACHE_TAG = 'cms_b';
 
     /**#@+
      * Block's statuses
      */
-    const STATUS_ENABLED = 1;
-    const STATUS_DISABLED = 0;
+    public const STATUS_ENABLED = 1;
+    public const STATUS_DISABLED = 0;
 
-    /**#@-*/
-
-    /**#@-*/
+    /**
+     * @var string
+     */
     protected $_cacheTag = self::CACHE_TAG;
 
     /**

app/code/Magento/Cms/Model/Block/DataProvider.php

@@ -30,8 +30,6 @@ class DataProvider extends \Magento\Ui\DataProvider\ModifierPoolDataProvider
     protected $loadedData;
 
     /**
-     * Constructor
-     *
      * @param string $name
      * @param string $primaryFieldName
      * @param string $requestFieldName

app/code/Magento/Sales/Model/Order.php

@@ -2029,6 +2029,7 @@ public function getRelatedObjects()
      * Get customer name
      *
      * @return string
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function getCustomerName()
     {

lib/internal/Magento/Framework/Image/Adapter/Gd2.php

@@ -17,8 +17,6 @@
 class Gd2 extends AbstractAdapter
 {
     /**
-     * Required extensions
-     *
      * @var array
      */
     protected $_requiredExtensions = ["gd"];
@@ -475,6 +473,7 @@ public function watermark($imagePath, $positionX = 0, $positionY = 0, $opacity =
      * @return false|resource
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     private function createWatermarkBasedOnPosition(
         $watermark,

lib/internal/Magento/Framework/Search/Dynamic/Algorithm/Auto.php

@@ -34,7 +34,7 @@ public function __construct(DataProviderInterface $dataProvider, OptionsInterfac
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getItems(
         BucketInterface $bucket,
@@ -53,6 +53,8 @@ public function getItems(
     }
 
     /**
+     * Returns price range.
+     *
      * @param BucketInterface $bucket
      * @param array $dimensions
      * @param EntityStorage $entityStorage
@@ -84,6 +86,8 @@ private function getMaxPriceInt(EntityStorage $entityStorage)
     }
 
     /**
+     * Return Minimal range power.
+     *
      * @return int
      */
     private function getMinRangePower()

setup/src/Magento/Setup/Console/Command/GenerateFixturesCommand.php

@@ -21,12 +21,9 @@
  */
 class GenerateFixturesCommand extends Command
 {
-    /**
-     * Profile argument
-     */
-    const PROFILE_ARGUMENT = 'profile';
+    public const PROFILE_ARGUMENT = 'profile';
 
-    const SKIP_REINDEX_OPTION = 'skip-reindex';
+    public const SKIP_REINDEX_OPTION = 'skip-reindex';
 
     /**
      * @var FixtureModel
@@ -43,7 +40,7 @@ public function __construct(FixtureModel $fixtureModel)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function configure()
     {
@@ -66,7 +63,7 @@ protected function configure()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -158,6 +155,8 @@ private function clearChangelog()
     }
 
     /**
+     * Executes fixture and output the execution time.
+     *
      * @param \Magento\Setup\Fixtures\Fixture $fixture
      * @param OutputInterface $output
      */

setup/src/Magento/Setup/Model/BatchInsert.php

@@ -58,8 +58,7 @@ public function __construct(
     }
 
     /**
-     * Save data to $dataStorage and automatically flush it to DB
-     * when storage size becomes equal to $batchSize
+     * Save data to $dataStorage and automatically flush it to DB when storage size becomes equal to $batchSize
      *
      * @param array $dataToInsert
      * @return void