Skip to content

Update package to use context.Context for go-github calls #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradbyte opened this issue Feb 28, 2017 · 1 comment
Closed

Update package to use context.Context for go-github calls #2

bradbyte opened this issue Feb 28, 2017 · 1 comment
Labels
fixed

Comments

@bradbyte
Copy link

Hello,

I'm utilizing your Iris router on a project and am now unable to deploy my app because of this error:

remote: vendor/github.com/kataras/go-fs/updater.go:62: not enough arguments in call to client.Repositories.GetLatestRelease
remote: 	have (string, string)
remote: 	want (context.Context, string, string)

Reading this issue on go-github, it seems they've made a breaking API change that requires context.Context as the first param on all methods. I'm not sure how you want to handle the context, but I was able to get my local project working by passing a new instance of context from context.TODO() to the call. I can make a PR with what I did for your review.

Thanks!
@bradbyte bradbyte mentioned this issue Feb 28, 2017
Merged
@ghost ghost added the fixed label Feb 28, 2017
@ghost ghost closed this as completed Feb 28, 2017
@bliuchak
Copy link

@kataras, are you planning to make an new release for gopkg.in/kataras/go-fs.v0?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bliuchak @bradbyte