Skip to content

Message should be function and added test cases for the coverage as well #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Conversation

antsmartian
Copy link
Collaborator

@antsmartian antsmartian commented Mar 30, 2018

What: Jest message should be a function, we have returned a string, so in case of failure, the API is breaking.

Why:

How: Moved them to functions and wrote coverage test cases for them as well.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@antsmartian
Copy link
Collaborator Author

antsmartian commented Mar 30, 2018

@kentcdodds Before I merge this, I wanted to check the test cases I have added is mainly for coverage. Not sure element-queries.js is the right place to put. Yes, I have left the comment, but still want to cross check with you, if this is the right place to do so.

@codecov
Copy link

codecov bot commented Mar 30, 2018

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          81     85    +4     
  Branches       19     19           
=====================================
+ Hits           81     85    +4
Impacted Files Coverage Δ
src/jest-extensions.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f01eeb...71850bc. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Thanks!

@kentcdodds kentcdodds merged commit fd2df8d into testing-library:master Mar 30, 2018
@kentcdodds
Copy link
Member

Remember that if you merge things yourself (generally I'd prefer to review PRs first) that you should use the Squash and Merge feature and that the commit message you set it to follows the convention. See other/MAINTAINING.md for more info :)

Thanks!

@antsmartian
Copy link
Collaborator Author

@kentcdodds Yes, sure. Will mostly give it for a review though. Thanks for merging it.

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants